From 7167de5f80c58910a6004fe1ab4fc5b086ae20b8 Mon Sep 17 00:00:00 2001
From: Thomas Hartmann <thomas.hartmann@qt.io>
Date: Mon, 29 Nov 2021 14:31:48 +0100
Subject: [PATCH] StudioWelcome: Change connection syntax to suppress warnings

Change-Id: Iad243630788a719639dfa9d9e5e1fd753412f7d6
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
---
 .../qmldesigner/welcomepage/ExpandToggle.ui.qml        |  2 +-
 .../qmldesigner/welcomepage/FavoriteToggle.qml         |  2 +-
 share/qtcreator/qmldesigner/welcomepage/MainScreen.qml | 10 +++++-----
 .../qmldesigner/welcomepage/TestControlPanel.qml       | 10 +++++-----
 .../qmldesigner/welcomepage/TwitterButton.qml          |  2 +-
 share/qtcreator/qmldesigner/welcomepage/ViewToggle.qml |  2 +-
 .../qmldesigner/welcomepage/YoutubeButton.qml          |  2 +-
 7 files changed, 15 insertions(+), 15 deletions(-)

diff --git a/share/qtcreator/qmldesigner/welcomepage/ExpandToggle.ui.qml b/share/qtcreator/qmldesigner/welcomepage/ExpandToggle.ui.qml
index 5272489e525..02f8be68035 100644
--- a/share/qtcreator/qmldesigner/welcomepage/ExpandToggle.ui.qml
+++ b/share/qtcreator/qmldesigner/welcomepage/ExpandToggle.ui.qml
@@ -53,7 +53,7 @@ Item {
 
         Connections {
             target: mouseAreaToggle
-            onReleased: expandToggle.collapsed = !expandToggle.collapsed
+            function onReleased(mouse) { expandToggle.collapsed = !expandToggle.collapsed }
         }
     }
     states: [
diff --git a/share/qtcreator/qmldesigner/welcomepage/FavoriteToggle.qml b/share/qtcreator/qmldesigner/welcomepage/FavoriteToggle.qml
index fcdb7e086d9..f8a58c941fd 100644
--- a/share/qtcreator/qmldesigner/welcomepage/FavoriteToggle.qml
+++ b/share/qtcreator/qmldesigner/welcomepage/FavoriteToggle.qml
@@ -58,7 +58,7 @@ Item {
 
         Connections {
             target: mouseArea
-            onReleased: favoriteToggle.isFavorite = !favoriteToggle.isFavorite
+            function onReleased(mouse) { favoriteToggle.isFavorite = !favoriteToggle.isFavorite }
         }
     }
     states: [
diff --git a/share/qtcreator/qmldesigner/welcomepage/MainScreen.qml b/share/qtcreator/qmldesigner/welcomepage/MainScreen.qml
index 6c0dc429771..ff47815a8f1 100644
--- a/share/qtcreator/qmldesigner/welcomepage/MainScreen.qml
+++ b/share/qtcreator/qmldesigner/welcomepage/MainScreen.qml
@@ -140,7 +140,7 @@ Rectangle {
 
             Connections {
                 target: recentProjects
-                onClicked: appBackground.pageIndex = 0
+                function onClicked(mouse) { appBackground.pageIndex = 0 }
             }
         }
 
@@ -152,7 +152,7 @@ Rectangle {
 
             Connections {
                 target: examples
-                onClicked: appBackground.pageIndex = 1
+                function onClicked(mouse) { appBackground.pageIndex = 1 }
             }
         }
 
@@ -164,7 +164,7 @@ Rectangle {
 
             Connections {
                 target: tutorials
-                onClicked: appBackground.pageIndex = 2
+                function onClicked(moise) { appBackground.pageIndex = 2 }
             }
         }
 
@@ -177,7 +177,7 @@ Rectangle {
 
             Connections {
                 target: marketplace
-                onClicked: appBackground.pageIndex = 3
+                function onClicked() { appBackground.pageIndex = 3 }
             }
         }
     }
@@ -341,7 +341,7 @@ Rectangle {
 
         Connections {
             target: listGridToggle
-            onViewDefaultChanged: Constants.isListView = !Constants.isListView
+            function onViewDefaultChanged() { Constants.isListView = !Constants.isListView }
         }
     }
 
diff --git a/share/qtcreator/qmldesigner/welcomepage/TestControlPanel.qml b/share/qtcreator/qmldesigner/welcomepage/TestControlPanel.qml
index 1445c59b168..40a22337f18 100644
--- a/share/qtcreator/qmldesigner/welcomepage/TestControlPanel.qml
+++ b/share/qtcreator/qmldesigner/welcomepage/TestControlPanel.qml
@@ -52,7 +52,7 @@ Item {
             y: 119
             text: qsTr("")
             checked: true
-            onToggled: Constants.basic = !Constants.basic
+            onToggled: { Constants.basic = !Constants.basic }
         }
 
         CheckBox {
@@ -61,7 +61,7 @@ Item {
             y: 119
             text: qsTr("")
             checked: false
-            onToggled: Constants.communityEdition = !Constants.communityEdition
+            onToggled: { Constants.communityEdition = !Constants.communityEdition }
         }
     }
 
@@ -79,7 +79,7 @@ Item {
 
         Connections {
             target: themeSlider
-            onValueChanged: Theme.Values.style = themeSlider.value
+            function onValueChanged(value) { Theme.Values.style = themeSlider.value }
         }
     }
 
@@ -103,7 +103,7 @@ Item {
         display: AbstractButton.IconOnly
         Connections {
             target: brandSwitch
-            onToggled: Constants.defaultBrand = !Constants.defaultBrand
+            function onToggled(bool) { Constants.defaultBrand = !Constants.defaultBrand }
         }
     }
 
@@ -185,7 +185,7 @@ Item {
 
             Connections {
                 target: mouseArea
-                onClicked: controlPanel.closeOpen = !controlPanel.closeOpen
+                function onClicked(mouse) { controlPanel.closeOpen = !controlPanel.closeOpen }
             }
         }
     }
diff --git a/share/qtcreator/qmldesigner/welcomepage/TwitterButton.qml b/share/qtcreator/qmldesigner/welcomepage/TwitterButton.qml
index 975ff5c2efc..a7d93168264 100644
--- a/share/qtcreator/qmldesigner/welcomepage/TwitterButton.qml
+++ b/share/qtcreator/qmldesigner/welcomepage/TwitterButton.qml
@@ -60,7 +60,7 @@ Item {
         hoverEnabled: true
         Connections {
             target: mouseArea
-            onClicked: Qt.openUrlExternally("https://twitter.com/qtproject/")
+            function onClicked(mouse) { Qt.openUrlExternally("https://twitter.com/qtproject/") }
         }
     }
     states: [
diff --git a/share/qtcreator/qmldesigner/welcomepage/ViewToggle.qml b/share/qtcreator/qmldesigner/welcomepage/ViewToggle.qml
index 98215ac6c2e..58e210ec553 100644
--- a/share/qtcreator/qmldesigner/welcomepage/ViewToggle.qml
+++ b/share/qtcreator/qmldesigner/welcomepage/ViewToggle.qml
@@ -136,7 +136,7 @@ Rectangle {
 
         Connections {
             target: mouseArea
-            onClicked: listGrid.viewDefault = !listGrid.viewDefault
+            function onClicked(mouse) { listGrid.viewDefault = !listGrid.viewDefault }
         }
     }
     states: [
diff --git a/share/qtcreator/qmldesigner/welcomepage/YoutubeButton.qml b/share/qtcreator/qmldesigner/welcomepage/YoutubeButton.qml
index 4b317ce72a6..062ea104078 100644
--- a/share/qtcreator/qmldesigner/welcomepage/YoutubeButton.qml
+++ b/share/qtcreator/qmldesigner/welcomepage/YoutubeButton.qml
@@ -68,7 +68,7 @@ Item {
 
         Connections {
             target: mouseArea
-            onClicked: Qt.openUrlExternally("https://www.youtube.com/user/QtStudios/")
+            function onClicked(mouse) { Qt.openUrlExternally("https://www.youtube.com/user/QtStudios/") }
         }
     }
     states: [