feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Axivion: Fix crash on close

Browse Source 
Fixes disconnecting the correct connection.
Amends 99aed851ef.

Change-Id: I3175291086b08ad5434c4211aba51bd5eb439e24
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2024-03-27 08:53:49 +01:00
parent 1fdb2cbe53
commit 718fdcc607
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/axivion/axivionplugin.cpp
View File

@@ -238,6 +238,7 @@ public:
std::unordered_map<IDocument *, std::unique_ptr<TaskTree>> m_docMarksTrees; std::unordered_map<IDocument *, std::unique_ptr<TaskTree>> m_docMarksTrees;
TaskTreeRunner m_issueInfoRunner; TaskTreeRunner m_issueInfoRunner;
FileInProjectFinder m_fileFinder; // FIXME maybe obsolete when path mapping is implemented FileInProjectFinder m_fileFinder; // FIXME maybe obsolete when path mapping is implemented
QMetaObject::Connection m_fileFinderConnection;
}; };
static AxivionPluginPrivate *dd = nullptr; static AxivionPluginPrivate *dd = nullptr;
@@ -332,7 +333,7 @@ void AxivionPluginPrivate::onStartupProjectChanged(Project *project)
return; return;
if (m_project) if (m_project)
disconnect(m_project, &Project::fileListChanged, this, &AxivionPluginPrivate::handleOpenedDocs); disconnect(m_fileFinderConnection);
m_project = project; m_project = project;
clearAllMarks(); clearAllMarks();
@@ -346,7 +347,7 @@ void AxivionPluginPrivate::onStartupProjectChanged(Project *project)
} }
m_fileFinder.setProjectDirectory(m_project->projectDirectory()); m_fileFinder.setProjectDirectory(m_project->projectDirectory());
connect(m_project, &Project::fileListChanged, this, [this]{ m_fileFinderConnection = connect(m_project, &Project::fileListChanged, this, [this] {
m_fileFinder.setProjectFiles(m_project->files(Project::AllFiles)); m_fileFinder.setProjectFiles(m_project->files(Project::AllFiles));
handleOpenedDocs(); handleOpenedDocs();
}); });