feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Use LayoutBuilder in Gerrit options page

Browse Source 
Move towards using aspects and away from IOptionPage's QObject
base.

Change-Id: I07850a6b8e9fa7d2591efc6f76a23f249dfc164f
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2023-05-08 15:25:08 +02:00
parent 5a318df0ee
commit 72093746ac
4 changed files with 77 additions and 83 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/git/gerrit/gerritplugin.cpp
View File

@@ -156,13 +156,22 @@ GerritPlugin::GerritPlugin()
: m_parameters(new GerritParameters)
, m_server(new GerritServer)
{
m_parameters->fromSettings(ICore::settings());
m_gerritOptionsPage = new GerritOptionsPage(m_parameters,
[this] {
if (m_dialog)
m_dialog->scheduleUpdateRemotes();
});
}
GerritPlugin::~GerritPlugin() = default;
GerritPlugin::~GerritPlugin()
{
delete m_gerritOptionsPage;
}
void GerritPlugin::addToMenu(ActionContainer *ac)
{
m_parameters->fromSettings(ICore::settings());
QAction *openViewAction = new QAction(Git::Tr::tr("Gerrit..."), this);
@@ -177,13 +186,6 @@ void GerritPlugin::addToMenu(ActionContainer *ac)
ActionManager::registerAction(pushAction, Constants::GERRIT_PUSH);
connect(pushAction, &QAction::triggered, this, [this] { push(); });
ac->addAction(m_pushToGerritCommand);
auto options = new GerritOptionsPage(m_parameters, this);
connect(options, &GerritOptionsPage::settingsChanged,
this, [this] {
if (m_dialog)
m_dialog->scheduleUpdateRemotes();
});
}
void GerritPlugin::updateActions(const VcsBase::VcsBasePluginState &state)