feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangCodeModel: Add missing check in findLocalUsages()

Browse Source 
When trying to find out whether a symbol refers to a local variable, we
first look up its definition. Afterwards, we need to check whether that
definition is located in the same file. This was forgotten, which lead to
seemingly random weirdness when trying to rename non-local symbols.

Change-Id: Icdcfd5583bf33346d8f0e3caf2751fd16f7d9602
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Kandeler
2022-09-20 15:28:58 +02:00
parent c23155cdd4
commit 720d07928b
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/clangcodemodel/clangdclient.cpp
View File

@@ -1691,7 +1691,8 @@ void ClangdClient::findLocalUsages(TextDocument *document, const QTextCursor &cu
<< link.targetLine << (link.targetColumn + 1); << link.targetLine << (link.targetColumn + 1);
if (!d->localRefsData || id != d->localRefsData->id) if (!d->localRefsData || id != d->localRefsData->id)
return; return;
if (!link.hasValidTarget()) { if (!link.hasValidTarget() || !d->localRefsData->document
|| d->localRefsData->document->filePath() != link.targetFilePath) {
d->localRefsData.reset(); d->localRefsData.reset();
return; return;
} }