From 720dbf557f2395fb98533092a65724f598168eab Mon Sep 17 00:00:00 2001 From: Eike Ziller Date: Mon, 1 Mar 2021 14:57:56 +0100 Subject: [PATCH] PluginManager: Remove plugin crash check at shutdown The check was mostly introduced for the case where Qt Creator crashes at startup. For example if the user enabled or installed a plugin that makes Qt Creator crash at startup, they get the chance to temporarily disable that plugin because otherwise they cannot even access the plugin dialog. For shutdown that makes less sense, and is irritating for development. Change-Id: I7267d74f4bb2d302c946a7488cc645ca4c7f864b Reviewed-by: David Schulz --- src/libs/extensionsystem/pluginmanager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libs/extensionsystem/pluginmanager.cpp b/src/libs/extensionsystem/pluginmanager.cpp index adfe161ba8e..ab83ed210b4 100644 --- a/src/libs/extensionsystem/pluginmanager.cpp +++ b/src/libs/extensionsystem/pluginmanager.cpp @@ -1474,7 +1474,7 @@ void PluginManagerPrivate::loadPlugin(PluginSpec *spec, PluginSpec::State destSt return; std::unique_ptr lockFile; - if (enableCrashCheck) + if (enableCrashCheck && destState < PluginSpec::Stopped) lockFile.reset(new LockFile(this, spec)); switch (destState) {