feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Editors: Automatically add editor/document id to context and use that

Browse Source 
instead of manually adding a context everywhere.

Change-Id: I4336015a6d19349171a255e949da89b0013d6700
Reviewed-by: hjk <hjk121@nokiamail.com>
This commit is contained in:
Eike Ziller
2014-09-02 12:25:20 +02:00
committed by hjk
parent cae737e629
commit 7224ccb2e7
39 changed files with 33 additions and 110 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/perforce/perforceplugin.cpp
View File

@@ -84,36 +84,29 @@ const char SUBMIT_MIMETYPE[] = "text/vnd.qtcreator.p4.submit";
const char PERFORCE_SUBMIT_EDITOR_ID[] = "Perforce.SubmitEditor";
const char PERFORCE_SUBMIT_EDITOR_DISPLAY_NAME[] = QT_TRANSLATE_NOOP("VCS", "Perforce.SubmitEditor");
const char PERFORCESUBMITEDITOR_CONTEXT[] = "Perforce Submit Editor";
const char PERFORCE_LOG_EDITOR_ID[] = "Perforce.LogEditor";
const char PERFORCE_LOG_EDITOR_DISPLAY_NAME[] = QT_TRANSLATE_NOOP("VCS", "Perforce Log Editor");
const char PERFORCE_LOG_EDITOR_CONTEXT[] = "Perforce Log Editor";
const char PERFORCE_DIFF_EDITOR_ID[] = "Perforce.DiffEditor";
const char PERFORCE_DIFF_EDITOR_DISPLAY_NAME[] = QT_TRANSLATE_NOOP("VCS", "Perforce Diff Editor");
const char PERFORCE_DIFF_EDITOR_CONTEXT[] = "Perforce Diff Editor";
const char PERFORCE_ANNOTATION_EDITOR_ID[] = "Perforce.AnnotationEditor";
const char PERFORCE_ANNOTATION_EDITOR_DISPLAY_NAME[] = QT_TRANSLATE_NOOP("VCS", "Perforce Annotation Editor");
const char PERFORCE_ANNOTATION_EDITOR_CONTEXT[] = "Perforce Annotation Editor";
const VcsBaseEditorParameters editorParameters[] = {
{
VcsBase::LogOutput,
PERFORCE_LOG_EDITOR_ID,
PERFORCE_LOG_EDITOR_DISPLAY_NAME,
PERFORCE_LOG_EDITOR_CONTEXT,
"text/vnd.qtcreator.p4.log"},
{ VcsBase::AnnotateOutput,
PERFORCE_ANNOTATION_EDITOR_ID,
PERFORCE_ANNOTATION_EDITOR_DISPLAY_NAME,
PERFORCE_ANNOTATION_EDITOR_CONTEXT,
"text/vnd.qtcreator.p4.annotation"},
{ VcsBase::DiffOutput,
PERFORCE_DIFF_EDITOR_ID,
PERFORCE_DIFF_EDITOR_DISPLAY_NAME,
PERFORCE_DIFF_EDITOR_CONTEXT,
"text/x-patch"}
};
@@ -221,7 +214,6 @@ static const VcsBaseSubmitEditorParameters submitParameters = {
SUBMIT_MIMETYPE,
PERFORCE_SUBMIT_EDITOR_ID,
PERFORCE_SUBMIT_EDITOR_DISPLAY_NAME,
PERFORCESUBMITEDITOR_CONTEXT,
VcsBaseSubmitEditorParameters::DiffFiles
};
@@ -259,7 +251,7 @@ bool PerforcePlugin::initialize(const QStringList & /* arguments */, QString *er
m_menuAction = mperforce->menu()->menuAction();
Context globalcontext(Core::Constants::C_GLOBAL);
Context perforcesubmitcontext(PERFORCESUBMITEDITOR_CONTEXT);
Context perforcesubmitcontext(PERFORCE_SUBMIT_EDITOR_ID);
Core::Command *command;