feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Use normal object for settings

Browse Source 
Ownership is clear here.

However, since this is accessed via the static plugin interface,
this needed some change that access.

Change-Id: I9488a242442303dee89006240f787677afab730a
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2020-02-28 12:27:13 +01:00
parent 9da71b940a
commit 722705e1e7
6 changed files with 26 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/autotest/autotestplugin.h
View File

@@ -29,8 +29,6 @@
#include <extensionsystem/iplugin.h>
#include <QMap>
namespace ProjectExplorer {
class Project;
class RunConfiguration;
@@ -65,7 +63,7 @@ public:
void extensionsInitialized() override;
ShutdownFlag aboutToShutdown() override;
static QSharedPointer<TestSettings> settings();
static TestSettings *settings();
static TestProjectSettings *projectSettings(ProjectExplorer::Project *project);
static void updateMenuItemsEnabledState();
static void cacheRunConfigChoice(const QString &buildTargetKey, const ChoicePair &choice);
@@ -75,8 +73,6 @@ public:
private:
QVector<QObject *> createTestObjects() const override;
class AutotestPluginPrivate *d = nullptr;
const QSharedPointer<TestSettings> m_settings;
};
} // namespace Internal