feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LSP: restrict automatic completion

Browse Source 
Only request an automatic completion if the cursor is after at least 3
'identifier' characters (alphanumerical characters and underscore).

Change-Id: I1bac8f184042fb68135ce24c20d17fc134aae5ac
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
David Schulz
2018-10-09 14:30:41 +02:00
parent a2a29d1861
commit 727ea78a5d
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/languageclient/languageclientcodeassist.cpp
View File

@@ -247,11 +247,15 @@ TextEditor::IAssistProposal *LanguageClientCompletionAssistProcessor::perform(
{
QTC_ASSERT(m_client, return nullptr);
m_pos = interface->position();
// const QRegExp regexp("[_a-zA-Z][_a-zA-Z0-9]*"); // FIXME
// int delta = 0;
// while (m_pos - delta > 0 && regexp.exactMatch(interface->textAt(m_pos - delta - 1, delta + 1)))
// ++delta;
// m_pos -= delta;
if (interface->reason() == TextEditor::IdleEditor) {
// Trigger an automatic completion request only when we are on a word with more than 2 "identifier" character
const QRegExp regexp("[_a-zA-Z0-9]*");
int delta = 0;
while (m_pos - delta > 0 && regexp.exactMatch(interface->textAt(m_pos - delta - 1, delta + 1)))
++delta;
if (delta < 3)
return nullptr;
}
CompletionRequest completionRequest;
CompletionParams::CompletionContext context;
context.setTriggerKind(interface->reason() == TextEditor::ActivationCharacter