feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Cache file lookup when loading events

Browse Source 
The file lookup is the single most expensive operation when loading
events from a profiled application, in particular because so far we're
doing one lookup per source location, many of which are actually in the
same files. Caching those lookups for a short time dramatically
increases performance.

Change-Id: Iaa47327aca3f34cbad194757d3ba152205788682
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
This commit is contained in:
Ulf Hermann
2014-03-07 13:04:04 +01:00
parent 6975be4f54
commit 72d1850a0d
1 changed files with 10 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/qmlprofiler/qmlprofilerdetailsrewriter.cpp
View File

@@ -108,6 +108,7 @@ public:
QList <PendingEvent> m_pendingEvents; QList <PendingEvent> m_pendingEvents;
QStringList m_pendingDocs; QStringList m_pendingDocs;
Utils::FileInProjectFinder *m_projectFinder; Utils::FileInProjectFinder *m_projectFinder;
QMap<QString, QString> m_filesCache;
QmlProfilerDetailsRewriter *q; QmlProfilerDetailsRewriter *q;
}; };
@@ -125,7 +126,13 @@ QmlProfilerDetailsRewriter::~QmlProfilerDetailsRewriter()
void QmlProfilerDetailsRewriter::requestDetailsForLocation(int requestId, void QmlProfilerDetailsRewriter::requestDetailsForLocation(int requestId,
const QmlDebug::QmlEventLocation &location) const QmlDebug::QmlEventLocation &location)
{ {
const QString localFile = d->m_projectFinder->findFile(location.filename); QString localFile;
if (!d->m_filesCache.contains(location.filename)) {
localFile = d->m_projectFinder->findFile(location.filename);
d->m_filesCache[location.filename] = localFile;
} else {
localFile = d->m_filesCache[location.filename];
}
QFileInfo fileInfo(localFile); QFileInfo fileInfo(localFile);
if (!fileInfo.exists() || !fileInfo.isReadable()) if (!fileInfo.exists() || !fileInfo.isReadable())
return; return;
@@ -173,6 +180,7 @@ void QmlProfilerDetailsRewriter::rewriteDetailsForLocation(QTextStream &textDoc,
void QmlProfilerDetailsRewriter::clearRequests() void QmlProfilerDetailsRewriter::clearRequests()
{ {
d->m_filesCache.clear();
d->m_pendingDocs.clear(); d->m_pendingDocs.clear();
} }
@@ -204,6 +212,7 @@ void QmlProfilerDetailsRewriter::documentReady(QmlJS::Document::Ptr doc)
this, this,
SLOT(documentReady(QmlJS::Document::Ptr))); SLOT(documentReady(QmlJS::Document::Ptr)));
emit eventDetailsChanged(); emit eventDetailsChanged();
d->m_filesCache.clear();
} }
} }