Use qAsConst with non-const Qt containers in range-loops

... in various places

Change-Id: Ic6c0c1b9437a1ed402105c7a14a1f5f9454a68d4
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>

src/plugins/autotest/qtest/qttestparser.cpp

@@ -148,7 +148,7 @@ static CPlusPlus::Document::Ptr declaringDocument(CPlusPlus::Document::Ptr doc,
         }
     }
 
-    for (const CPlusPlus::LookupItem &item : lookupItems) {
+    for (const CPlusPlus::LookupItem &item : qAsConst(lookupItems)) {
         if (CPlusPlus::Symbol *symbol = item.declaration()) {
             if (CPlusPlus::Class *toeClass = symbol->asClass()) {
                 const QString declFileName = QLatin1String(toeClass->fileId()->chars(),

src/plugins/autotest/quick/quicktestparser.cpp

@@ -163,7 +163,7 @@ QList<Document::Ptr> QuickTestParser::scanDirectoryForQuickTestQmlFiles(const QS
 
     QList<Document::Ptr> foundDocs;
 
-    for (const QString &path : dirs) {
+    for (const QString &path : qAsConst(dirs)) {
         const QList<Document::Ptr> docs = snapshot.documentsInDirectory(path);
         for (const Document::Ptr &doc : docs) {
             const QFileInfo fi(doc->fileName());

src/plugins/autotest/testresultmodel.cpp

@@ -361,7 +361,7 @@ void TestResultModel::recalculateMaxWidthOfFileName(const QFont &font)
 {
     const QFontMetrics fm(font);
     m_maxWidthOfFileName = 0;
-    for (const QString &fileName : m_fileNames) {
+    for (const QString &fileName : qAsConst(m_fileNames)) {
         int pos = fileName.lastIndexOf('/');
         m_maxWidthOfFileName = qMax(m_maxWidthOfFileName, fm.horizontalAdvance(fileName.mid(pos + 1)));
     }

src/plugins/autotest/testresultspane.cpp

@@ -294,7 +294,7 @@ void TestResultsPane::addOutputLine(const QByteArray &outputLine, OutputChannel
 
     const Utils::FormattedText formattedText
             = Utils::FormattedText{QString::fromUtf8(outputLine), m_defaultFormat};
-    QList<Utils::FormattedText> formatted = channel == OutputChannel::StdOut
+    const QList<Utils::FormattedText> formatted = channel == OutputChannel::StdOut
             ? m_stdOutHandler.parseText(formattedText)
             : m_stdErrHandler.parseText(formattedText);
 

src/plugins/autotest/testtreemodel.cpp

@@ -381,7 +381,7 @@ void TestTreeModel::synchronizeTestTools()
     for (ITestTreeItem *oldFrameworkRoot : oldFrameworkRoots)
         takeItem(oldFrameworkRoot);  // do NOT delete the ptr is still held by TestFrameworkManager
 
-    for (ITestTool *testTool : tools) {
+    for (ITestTool *testTool : qAsConst(tools)) {
         ITestTreeItem *testToolRootNode = testTool->rootNode();
         if (testTool->active()) {
             invisibleRoot->appendChild(testToolRootNode);