feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use qAsConst with non-const Qt containers in range-loops

Browse Source 
... in various places

Change-Id: Ic6c0c1b9437a1ed402105c7a14a1f5f9454a68d4
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Alessandro Portale
2021-02-15 10:03:57 +01:00
parent 1d27f894bb
commit 72d91dc94a
55 changed files with 81 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/cmakebuildsystem.cpp
View File

@@ -578,7 +578,7 @@ void CMakeBuildSystem::updateProjectData()
{
QSet<QString> res;
QStringList apps;
for (const auto &target : m_buildTargets) {
for (const auto &target : qAsConst(m_buildTargets)) {
if (target.targetType == CMakeProjectManager::DynamicLibraryType) {
res.insert(target.executable.parentDir().toString());
apps.push_back(target.executable.toUserOutput());
@@ -633,7 +633,7 @@ void CMakeBuildSystem::updateProjectData()
}
patchedConfig.append(settingFileItem);
for (const CMakeBuildTarget &bt : m_buildTargets) {
for (const CMakeBuildTarget &bt : qAsConst(m_buildTargets)) {
const QString buildKey = bt.title;
if (ProjectNode *node = p->findNodeForBuildKey(buildKey)) {
if (auto targetNode = dynamic_cast<CMakeTargetNode *>(node))

2
src/plugins/cmakeprojectmanager/configmodel.cpp
View File

@@ -303,7 +303,7 @@ void ConfigModel::generateTree()
// Generate nodes for *all* prefixes
QHash<QString, QList<Utils::TreeItem *>> prefixes;
for (const InternalDataItem &di : m_configuration) {
for (const InternalDataItem &di : qAsConst(m_configuration)) {
const QString p = prefix(di.key);
if (!prefixes.contains(p)) {
prefixes.insert(p, {});