feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use qAsConst with non-const Qt containers in range-loops

Browse Source 
... in various places

Change-Id: Ic6c0c1b9437a1ed402105c7a14a1f5f9454a68d4
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Alessandro Portale
2021-02-15 10:03:57 +01:00
parent 1d27f894bb
commit 72d91dc94a
55 changed files with 81 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/qbsprojectmanager/qbsbuildstep.cpp
View File

@@ -827,7 +827,7 @@ void QbsBuildStepConfigWidget::applyCachedProperties()
Constants::QBS_INSTALL_ROOT_KEY});
if (m_qbsStep->m_selectedAbis->isManagedByTarget())
additionalSpecialKeys << Constants::QBS_ARCHITECTURES;
for (const QString &key : additionalSpecialKeys) {
for (const QString &key : qAsConst(additionalSpecialKeys)) {
const auto it = tmp.constFind(key);
if (it != tmp.cend())
data.insert(key, it.value());

2
src/plugins/qbsprojectmanager/qbsprofilemanager.cpp
View File

@@ -199,7 +199,7 @@ void QbsProfileManager::addProfileFromKit(const ProjectExplorer::Kit *k)
// set up properties:
QVariantMap data = m_defaultPropertyProvider->properties(k, QVariantMap());
for (PropertyProvider *provider : g_propertyProviders) {
for (PropertyProvider *provider : qAsConst(g_propertyProviders)) {
if (provider->canHandle(k))
data = provider->properties(k, data);
}

6
src/plugins/qbsprojectmanager/qbsproject.cpp
View File

@@ -141,11 +141,7 @@ ProjectImporter *QbsProject::projectImporter() const
void QbsProject::configureAsExampleProject(Kit *kit)
{
QList<BuildInfo> infoList;
QList<Kit *> kits;
if (kit)
kits.append(kit);
else
kits = KitManager::kits();
const QList<Kit *> kits(kit != nullptr ? QList<Kit *>({kit}) : KitManager::kits());
for (Kit *k : kits) {
if (QtSupport::QtKitAspect::qtVersion(k) != nullptr) {
if (auto factory = BuildConfigurationFactory::find(k, projectFilePath()))