feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Use qAsConst with non-const Qt containers in range-loops

Browse Source 
... in various places

Change-Id: Ic6c0c1b9437a1ed402105c7a14a1f5f9454a68d4
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Alessandro Portale
2021-02-15 10:03:57 +01:00
parent 1d27f894bb
commit 72d91dc94a
55 changed files with 81 additions and 85 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/qmakeprojectmanager/qmakeparsernodes.cpp
View File

@@ -1214,7 +1214,7 @@ QString QmakeProFile::displayName() const
QList<QmakeProFile *> QmakeProFile::allProFiles()
{
QList<QmakeProFile *> result = { this };
for (QmakePriFile *c : m_children) {
for (QmakePriFile *c : qAsConst(m_children)) {
auto proC = dynamic_cast<QmakeProFile *>(c);
if (proC)
result.append(proC->allProFiles());
@@ -1591,7 +1591,7 @@ QmakeEvalResult *QmakeProFile::evaluate(const QmakeEvalInput &input)
toCompare.pop_front();
// Loop prevention: Make sure that exact same node is not in our parent chain
for (QmakeIncludedPriFile *priFile : tree->children) {
for (QmakeIncludedPriFile *priFile : qAsConst(tree->children)) {
bool loop = input.parentFilePaths.contains(priFile->name);
for (const QmakePriFile *n = pn; n && !loop; n = n->parent()) {
if (n->filePath() == priFile->name)