From 72d932a44e15f17be79d87d037927ed1dfa7df2a Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Wed, 22 Sep 2021 13:52:23 +0200 Subject: [PATCH] QmlDesigner: Fix Coverity Scan defect dialog was just created and cannot be null. CID 1506796: Null pointer dereferences (REVERSE_INULL) Null-checking "dialog" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Change-Id: I53c116620c91b5b41b4028e367cb286e13193cf7 Reviewed-by: Tony Leinonen Reviewed-by: Miikka Heikkinen --- .../qmldesigner/components/navigator/navigatortreemodel.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp b/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp index cbf7f375996..5abc38eba69 100644 --- a/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp +++ b/src/plugins/qmldesigner/components/navigator/navigatortreemodel.cpp @@ -739,7 +739,7 @@ void NavigatorTreeModel::handleItemLibraryItemDrop(const QMimeData *mimeData, in ChooseFromPropertyListDialog *dialog = nullptr; dialog = new ChooseFromPropertyListDialog(targetNode, testType, Core::ICore::dialogParent()); dialog->exec(); - if (!dialog || dialog->result() == QDialog::Accepted) + if (dialog->result() == QDialog::Accepted) targetNode.bindingProperty(dialog->selectedProperty()).setExpression(newModelNode.validId()); delete dialog; break;