feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Cvs: Remove CvsPluginPrivate::cvsVersionControl

Browse Source 
Base implementation is good enough.

Change-Id: I9c608f5636a8b9d34375f9c8d690f9c90120c880
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
hjk
2020-01-29 09:00:42 +01:00
parent 95623ae011
commit 731a3f24da
4 changed files with 3 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/cvs/cvsplugin.cpp
View File

@@ -559,7 +559,7 @@ void CvsPluginPrivate::revertAll()
runCvs(state.topLevel(), args, m_client->vcsTimeoutS(),
VcsCommand::SshPasswordPrompt | VcsCommand::ShowStdOut);
if (revertResponse.result == CvsResponse::Ok)
cvsVersionControl()->emitRepositoryChanged(state.topLevel());
emit versionControl()->repositoryChanged(state.topLevel());
else
Core::AsynchronousMessageBox::warning(title,
tr("Revert failed: %1").arg(revertResponse.message));
@@ -597,7 +597,7 @@ void CvsPluginPrivate::revertCurrentFile()
runCvs(state.currentFileTopLevel(), args, m_client->vcsTimeoutS(),
VcsCommand::SshPasswordPrompt | VcsCommand::ShowStdOut);
if (revertResponse.result == CvsResponse::Ok)
cvsVersionControl()->emitFilesChanged(QStringList(state.currentFile()));
emit versionControl()->filesChanged(QStringList(state.currentFile()));
}
void CvsPluginPrivate::diffProject()
@@ -788,7 +788,7 @@ bool CvsPluginPrivate::update(const QString &topLevel, const QString &file)
VcsCommand::SshPasswordPrompt | VcsCommand::ShowStdOut);
const bool ok = response.result == CvsResponse::Ok;
if (ok)
cvsVersionControl()->emitRepositoryChanged(topLevel);
emit versionControl()->repositoryChanged(topLevel);
return ok;
}
@@ -1242,11 +1242,6 @@ bool CvsPluginPrivate::checkCVSDirectory(const QDir &directory) const
return QFileInfo(cvsDir).isDir();
}
CvsControl *CvsPluginPrivate::cvsVersionControl() const
{
return static_cast<CvsControl *>(versionControl());
}
#ifdef WITH_TESTS
void CvsPlugin::testDiffFileResolving_data()
{