feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

FancyLineEdit: Do not set empty tooltip for no reason

Browse Source 
If the tooltip was previously set, it is overridden on validate() even if
there's no reason to change it (e.g. there is no QValidator nor a
validation function).

Change-Id: I854f2cd4b1a8b52c8fc1ae579876aec8d10c0b8a
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
This commit is contained in:
Orgad Shaneh
2019-10-09 23:29:28 +03:00
committed by Orgad Shaneh
parent 28e4ed61af
commit 734b9097c7
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/utils/fancylineedit.cpp
View File

@@ -129,6 +129,7 @@ public:
bool m_isFiltering = false; bool m_isFiltering = false;
bool m_firstChange = true; bool m_firstChange = true;
bool m_toolTipSet = false;
QString m_lastFilterText; QString m_lastFilterText;
@@ -520,7 +521,10 @@ void FancyLineEdit::validate()
const bool validates = d->m_validationFunction(this, &d->m_errorMessage); const bool validates = d->m_validationFunction(this, &d->m_errorMessage);
const State newState = isDisplayingPlaceholderText ? DisplayingPlaceholderText const State newState = isDisplayingPlaceholderText ? DisplayingPlaceholderText
: (validates ? Valid : Invalid); : (validates ? Valid : Invalid);
if (!validates || d->m_toolTipSet) {
setToolTip(d->m_errorMessage); setToolTip(d->m_errorMessage);
d->m_toolTipSet = true;
}
// Changed..figure out if valid changed. DisplayingPlaceholderText is not valid, // Changed..figure out if valid changed. DisplayingPlaceholderText is not valid,
// but should not show error color. Also trigger on the first change. // but should not show error color. Also trigger on the first change.
if (newState != d->m_state || d->m_firstChange) { if (newState != d->m_state || d->m_firstChange) {