From 735aeb3e38c5ae14505b555c602700c971034aa2 Mon Sep 17 00:00:00 2001 From: Christian Stenger Date: Wed, 8 Aug 2018 12:38:23 +0200 Subject: [PATCH] AutoTest: Fix usage of line widget Adding the same widget to two different layouts obviously does not work. Create two separate widgets for this. Change-Id: I1c598d7ac45b7a13cea129a444697d64a607f243 Reviewed-by: David Schulz --- src/plugins/autotest/testrunner.cpp | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/src/plugins/autotest/testrunner.cpp b/src/plugins/autotest/testrunner.cpp index e895ce514d0..57574012ec4 100644 --- a/src/plugins/autotest/testrunner.cpp +++ b/src/plugins/autotest/testrunner.cpp @@ -623,6 +623,14 @@ void TestRunner::onFinished() /*************************************************************************************************/ +static QFrame *createLine(QWidget *parent) +{ + QFrame *line = new QFrame(parent); + line->setFrameShape(QFrame::HLine); + line->setFrameShadow(QFrame::Sunken); + return line; +} + RunConfigurationSelectionDialog::RunConfigurationSelectionDialog(const QString &buildTargetKey, QWidget *parent) : QDialog(parent) @@ -642,15 +650,11 @@ RunConfigurationSelectionDialog::RunConfigurationSelectionDialog(const QString & m_buttonBox->setStandardButtons(QDialogButtonBox::Cancel|QDialogButtonBox::Ok); m_buttonBox->button(QDialogButtonBox::Ok)->setDefault(true); - auto line = new QFrame(this); - line->setFrameShape(QFrame::HLine); - line->setFrameShadow(QFrame::Sunken); - auto formLayout = new QFormLayout; formLayout->setFieldGrowthPolicy(QFormLayout::AllNonFixedFieldsGrow); formLayout->addRow(m_details); formLayout->addRow(tr("Run Configuration:"), m_rcCombo); - formLayout->addRow(line); + formLayout->addRow(createLine(this)); formLayout->addRow(tr("Executable:"), m_executable); formLayout->addRow(tr("Arguments:"), m_arguments); formLayout->addRow(tr("Working Directory:"), m_workingDir); @@ -658,7 +662,7 @@ RunConfigurationSelectionDialog::RunConfigurationSelectionDialog(const QString & auto vboxLayout = new QVBoxLayout(this); vboxLayout->addLayout(formLayout); vboxLayout->addStretch(); - vboxLayout->addWidget(line); + vboxLayout->addWidget(createLine(this)); vboxLayout->addWidget(m_buttonBox); connect(m_rcCombo, &QComboBox::currentTextChanged,