From 736168497aa07de01717f53dd8c886d33a1334ea Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Fri, 27 Feb 2015 09:42:48 +0200 Subject: [PATCH] Utils: Avoid copy on FileName::toString() Takes ~6% of project loading Change-Id: Id277f6cc9d5666b9a383419959cfd37b936437f8 Reviewed-by: Daniel Teske --- src/libs/utils/fileutils.cpp | 4 ++-- src/libs/utils/fileutils.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libs/utils/fileutils.cpp b/src/libs/utils/fileutils.cpp index 2c8baf56249..9979f2d6a6d 100644 --- a/src/libs/utils/fileutils.cpp +++ b/src/libs/utils/fileutils.cpp @@ -548,9 +548,9 @@ QFileInfo FileName::toFileInfo() const } /// \returns a QString for passing on to QString based APIs -QString FileName::toString() const +const QString &FileName::toString() const { - return QString(*this); + return *this; } /// \returns a QString to display to the user diff --git a/src/libs/utils/fileutils.h b/src/libs/utils/fileutils.h index 1ffea746a70..920bbc70afe 100644 --- a/src/libs/utils/fileutils.h +++ b/src/libs/utils/fileutils.h @@ -71,7 +71,7 @@ public: static FileName fromLatin1(const QByteArray &filename); static FileName fromUserInput(const QString &filename); static FileName fromUtf8(const char *filename, int filenameSize = -1); - QString toString() const; + const QString &toString() const; QString toUserOutput() const; QString fileName(int pathComponents = 0) const; bool exists() const;