From 73874980efe0be383ee3db10fcaef503fa4148ba Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Tue, 31 Aug 2021 12:59:46 +0200 Subject: [PATCH] Don't leak BeautifierPluginPrivate on shutdown Properly delete QtcProcess used for version on shutdown. Change-Id: I325a267ba5bb28a82158d9c50802955804713be0 Reviewed-by: hjk --- src/plugins/beautifier/beautifierplugin.cpp | 7 +++++++ src/plugins/beautifier/beautifierplugin.h | 1 + 2 files changed, 8 insertions(+) diff --git a/src/plugins/beautifier/beautifierplugin.cpp b/src/plugins/beautifier/beautifierplugin.cpp index 534de41ce0e..bc5dde7ac5b 100644 --- a/src/plugins/beautifier/beautifierplugin.cpp +++ b/src/plugins/beautifier/beautifierplugin.cpp @@ -133,6 +133,13 @@ void BeautifierPlugin::extensionsInitialized() dd = new BeautifierPluginPrivate; } +ExtensionSystem::IPlugin::ShutdownFlag BeautifierPlugin::aboutToShutdown() +{ + delete dd; + dd = nullptr; + return SynchronousShutdown; +} + BeautifierPluginPrivate::BeautifierPluginPrivate() { updateActions(); diff --git a/src/plugins/beautifier/beautifierplugin.h b/src/plugins/beautifier/beautifierplugin.h index b3538820ec9..153870d49fa 100644 --- a/src/plugins/beautifier/beautifierplugin.h +++ b/src/plugins/beautifier/beautifierplugin.h @@ -49,6 +49,7 @@ public: private: bool initialize(const QStringList &arguments, QString *errorString) override; void extensionsInitialized() override; + ShutdownFlag aboutToShutdown() override; }; } // namespace Internal