CppEditor: ExtractFunction quick fix asks for access specifier

Task-number: QTCREATORBUG-12127
Change-Id: Ifb6ff22282f0f181e49a260e57307ec937f5dfb2
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@theqtcompany.com>

src/plugins/cppeditor/cppquickfix_test.cpp

@@ -4454,6 +4454,32 @@ void CppEditorPlugin::test_quickfix_ExtractFunction_data()
              "{\n"
              "    extracted();\n"
              "}\n");
+
+    QTest::newRow("class function")
+        << _("class Foo\n"
+             "{\n"
+             "private:\n"
+             "    void bar();\n"
+             "};\n\n"
+             "void Foo::bar()\n"
+             "{\n"
+             "    @{start}g();@{end}\n"
+             "}\n")
+        << _("class Foo\n"
+             "{\n"
+             "public:\n"
+             "    void extracted();\n\n"
+             "private:\n"
+             "    void bar();\n"
+             "};\n\n"
+             "void Foo::extracted()\n"
+             "{\n"
+             "    g();\n"
+             "}\n\n"
+             "void Foo::bar()\n"
+             "{\n"
+             "    extracted();\n"
+             "}\n");
 }
 
 void CppEditorPlugin::test_quickfix_ExtractFunction()

src/plugins/cppeditor/cppquickfixes.cpp

@@ -60,8 +60,11 @@
 #include <utils/qtcassert.h>
 
 #include <QApplication>
+#include <QComboBox>
+#include <QDialogButtonBox>
 #include <QDir>
 #include <QFileInfo>
+#include <QFormLayout>
 #include <QInputDialog>
 #include <QSharedPointer>
 #include <QStack>
@@ -3139,6 +3142,21 @@ void GenerateGetterSetter::match(const CppQuickFixInterface &interface,
 
 namespace {
 
+class ExtractFunctionOptions
+{
+public:
+    ExtractFunctionOptions() : access(InsertionPointLocator::Public)
+    {}
+
+    bool hasValidFunctionName() const
+    {
+        return !funcName.isEmpty() && isValidIdentifier(funcName);
+    }
+
+    QString funcName;
+    InsertionPointLocator::AccessSpec access;
+};
+
 class ExtractFunctionOperation : public CppQuickFixOperation
 {
 public:
@@ -3167,9 +3185,15 @@ public:
         CppRefactoringChanges refactoring(snapshot());
         CppRefactoringFilePtr currentFile = refactoring.file(fileName());
 
-        const QString &funcName = m_functionNameGetter ? m_functionNameGetter() : getFunctionName();
+        ExtractFunctionOptions options;
-        if (funcName.isEmpty())
+        if (m_functionNameGetter)
+            options.funcName = m_functionNameGetter();
+        else
+            options = getOptions();
+
+        if (!options.hasValidFunctionName())
             return;
+        const QString &funcName = options.funcName;
 
         Function *refFunc = m_refFuncDef->symbol;
 
@@ -3290,43 +3314,71 @@ public:
             InsertionPointLocator locator(refactoring);
             const QString fileName = QLatin1String(matchingClass->fileName());
             const InsertionLocation &location =
-                    locator.methodDeclarationInClass(fileName, matchingClass,
+                    locator.methodDeclarationInClass(fileName, matchingClass, options.access);
-                                                     InsertionPointLocator::Public);
             CppRefactoringFilePtr declFile = refactoring.file(fileName);
             change.clear();
             position = declFile->position(location.line(), location.column());
-            change.insert(position, funcDecl);
+            change.insert(position, location.prefix() + funcDecl + location.suffix());
             declFile->setChangeSet(change);
             declFile->appendIndentRange(ChangeSet::Range(position, position + 1));
             declFile->apply();
         }
     }
 
-    QString getFunctionName() const
+    ExtractFunctionOptions getOptions() const
     {
-        bool ok;
+        QDialog dlg;
-        QString name =
+        dlg.setWindowTitle(QCoreApplication::translate("QuickFix::ExtractFunction",
-                QInputDialog::getText(0,
+                                                       "Extract Function Refactoring"));
-                                      QCoreApplication::translate("QuickFix::ExtractFunction",
+        auto layout = new QFormLayout(&dlg);
-                                                                  "Extract Function Refactoring"),
-                                      QCoreApplication::translate("QuickFix::ExtractFunction",
-                                                                  "Enter function name"),
-                                      QLineEdit::Normal,
-                                      QString(),
-                                      &ok);
-        name = name.trimmed();
-        if (!ok || name.isEmpty())
-            return QString();
 
-        if (!isValidIdentifier(name)) {
+        auto funcNameEdit = new QLineEdit;
-            Core::AsynchronousMessageBox::critical(QCoreApplication::translate("QuickFix::ExtractFunction",
+        layout->addRow(QCoreApplication::translate("QuickFix::ExtractFunction",
-                                                                               "Extract Function Refactoring"),
+                                                   "Function name"), funcNameEdit);
-                                                   QCoreApplication::translate("QuickFix::ExtractFunction",
+
-                                                              "Invalid function name"));
+        auto accessCombo = new QComboBox;
-            return QString();
+        accessCombo->addItem(
+                    InsertionPointLocator::accessSpecToString(InsertionPointLocator::Public),
+                    InsertionPointLocator::Public);
+        accessCombo->addItem(
+                    InsertionPointLocator::accessSpecToString(InsertionPointLocator::PublicSlot),
+                    InsertionPointLocator::PublicSlot);
+        accessCombo->addItem(
+                    InsertionPointLocator::accessSpecToString(InsertionPointLocator::Protected),
+                    InsertionPointLocator::Protected);
+        accessCombo->addItem(
+                    InsertionPointLocator::accessSpecToString(InsertionPointLocator::ProtectedSlot),
+                    InsertionPointLocator::ProtectedSlot);
+        accessCombo->addItem(
+                    InsertionPointLocator::accessSpecToString(InsertionPointLocator::Private),
+                    InsertionPointLocator::Private);
+        accessCombo->addItem(
+                    InsertionPointLocator::accessSpecToString(InsertionPointLocator::PrivateSlot),
+                    InsertionPointLocator::PrivateSlot);
+        layout->addRow(QCoreApplication::translate("QuickFix::ExtractFunction",
+                                                   "Access"), accessCombo);
+
+        auto buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel);
+        QObject::connect(buttonBox, &QDialogButtonBox::accepted, &dlg, &QDialog::accept);
+        QObject::connect(buttonBox, &QDialogButtonBox::rejected, &dlg, &QDialog::reject);
+        layout->addWidget(buttonBox);
+
+        if (dlg.exec() == QDialog::Accepted) {
+            ExtractFunctionOptions options;
+            options.funcName = funcNameEdit->text().trimmed();
+            options.access = static_cast<InsertionPointLocator::AccessSpec>(accessCombo->
+                                                                           currentData().toInt());
+            if (!options.hasValidFunctionName()) {
+                Core::AsynchronousMessageBox::critical(
+                            QCoreApplication::translate("QuickFix::ExtractFunction",
+                                                        "Extract Function Refactoring"),
+                            QCoreApplication::translate("QuickFix::ExtractFunction",
+                                                        "Invalid function name"));
+                return ExtractFunctionOptions();
+            }
+            return options;
         }
-
+        return ExtractFunctionOptions();
-        return name;
     }
 
     int m_extractionStart;