feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove unusual {Arguments,WorkingDir}Aspect

Browse Source 
Follows suite to 2cc4967 to have the user side code more uniform.
Most of the extra verbosity (setMacroExpander) can go away again
when distributing the expander via the "owning" AspectContainer.

Change-Id: I9e80cb235f0a4a9ebee601dd638aefbaa41efc1b
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
hjk
2023-07-05 08:56:05 +02:00
parent 7e0534c301
commit 739f835ef1
19 changed files with 128 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/android/androidrunconfiguration.cpp
View File

@@ -53,7 +53,8 @@ public:
auto envAspect = addAspect<EnvironmentAspect>();
envAspect->addSupportedBaseEnvironment(Tr::tr("Clean Environment"), {});
auto extraAppArgsAspect = addAspect<ArgumentsAspect>(macroExpander());
auto extraAppArgsAspect = addAspect<ArgumentsAspect>();
extraAppArgsAspect->setMacroExpander(macroExpander());
connect(extraAppArgsAspect, &BaseAspect::changed, this, [target, extraAppArgsAspect] {
if (target->buildConfigurations().first()->buildType() == BuildConfiguration::BuildType::Release) {