From 73d22499604f7e442023ee18b45cc1db349aae83 Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Wed, 24 Jul 2024 13:55:56 +0200
Subject: [PATCH] Android: Small cleanup in AndroidRunnerWorker

Remove unused constant and forward declaration.
Use nested namespaces.

Change-Id: Iccb7e2a836b38290da38c40532ebafc4b07c25a2
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
---
 src/plugins/android/androidrunnerworker.cpp |  6 ++----
 src/plugins/android/androidrunnerworker.h   | 17 ++++-------------
 2 files changed, 6 insertions(+), 17 deletions(-)

diff --git a/src/plugins/android/androidrunnerworker.cpp b/src/plugins/android/androidrunnerworker.cpp
index cd35a3ddc09..b0739cdaf43 100644
--- a/src/plugins/android/androidrunnerworker.cpp
+++ b/src/plugins/android/androidrunnerworker.cpp
@@ -47,8 +47,7 @@ using namespace std;
 using namespace std::chrono_literals;
 using namespace std::placeholders;
 
-namespace Android {
-namespace Internal {
+namespace Android::Internal {
 
 static const QString pidPollingScript = QStringLiteral("while [ -d /proc/%1 ]; do sleep 1; done");
 static const QRegularExpression userIdPattern("u(\\d+)_a");
@@ -861,5 +860,4 @@ void AndroidRunnerWorker::onProcessIdChanged(const PidUserPair &pidUser)
     }
 }
 
-} // namespace Internal
-} // namespace Android
+} // namespace Android::Internal
diff --git a/src/plugins/android/androidrunnerworker.h b/src/plugins/android/androidrunnerworker.h
index 033cf2d91ed..84f77e34eea 100644
--- a/src/plugins/android/androidrunnerworker.h
+++ b/src/plugins/android/androidrunnerworker.h
@@ -11,19 +11,11 @@
 #include <utils/environment.h>
 #include <utils/port.h>
 
-namespace Utils {
-class FilePath;
-class Process;
-}
+namespace Android { class AndroidDeviceInfo; }
 namespace ProjectExplorer { class RunWorker; }
+namespace Utils { class Process; }
 
-namespace Android {
-
-class AndroidDeviceInfo;
-
-namespace Internal {
-
-const int MIN_SOCKET_HANDSHAKE_PORT = 20001;
+namespace Android::Internal {
 
 using PidUserPair = std::pair<qint64, qint64>;
 
@@ -109,5 +101,4 @@ private:
     bool m_useAppParamsForQmlDebugger = false;
 };
 
-} // namespace Internal
-} // namespace Android
+} // namespace Android::Internal