feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LocatorFilterEntry: Get rid of internalData

Browse Source 
Change-Id: I2bcd64c39bdaf0fe8504b68ba4aaaef7cdcab475
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Jarek Kobus
2023-04-11 23:23:34 +02:00
parent 107d16fe34
commit 74322dfedf
2 changed files with 0 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/clangcodemodel/clangdlocatorfilters.cpp
View File

@@ -225,7 +225,6 @@ private:
entry.displayName = ClangdClient::displayNameFromDocumentSymbol( entry.displayName = ClangdClient::displayNameFromDocumentSymbol(
static_cast<SymbolKind>(info.kind()), info.name(), static_cast<SymbolKind>(info.kind()), info.name(),
info.detail().value_or(QString())); info.detail().value_or(QString()));
entry.internalData = QVariant::fromValue(info);
entry.linkForEditor = linkForDocSymbol(info); entry.linkForEditor = linkForDocSymbol(info);
entry.extraInfo = parent.extraInfo; entry.extraInfo = parent.extraInfo;
if (!entry.extraInfo.isEmpty()) if (!entry.extraInfo.isEmpty())

3
src/plugins/coreplugin/locator/ilocatorfilter.h
View File

@@ -99,9 +99,6 @@ public:
/* called by locator widget on accept. By default, when acceptor is empty, /* called by locator widget on accept. By default, when acceptor is empty,
EditorManager::openEditor(LocatorFilterEntry) will be used instead. */ EditorManager::openEditor(LocatorFilterEntry) will be used instead. */
Acceptor acceptor; Acceptor acceptor;
/* can be used by the filter to save more information about the entry */
/* Replaced by acceptor - DON'T USE IN NEW CODE, IT'S GOING TO BE REMOVED, SOON... */
QVariant internalData;
/* icon to display along with the entry */ /* icon to display along with the entry */
std::optional<QIcon> displayIcon; std::optional<QIcon> displayIcon;
/* file path, if the entry is related to a file, is used e.g. for resolving a file icon */ /* file path, if the entry is related to a file, is used e.g. for resolving a file icon */