From 743b5b74310d396ec45250e6424be49f652d9441 Mon Sep 17 00:00:00 2001 From: Leandro Melo Date: Tue, 31 May 2011 10:58:23 +0200 Subject: [PATCH] C++ editor: Normalize line endings for find usages Find usages and related rely on functions that assume \n as line ending. This is true for the preprocessed files, but not for the original sources. Change-Id: I61b7e05c0116504d11c7df4b1aa10d519b705336 Reviewed-on: http://codereview.qt.nokia.com/260 Reviewed-by: Qt Sanity Bot Reviewed-by: Erik Verbruggen --- src/plugins/cpptools/cppfindreferences.cpp | 2 +- src/plugins/cpptools/uicodecompletionsupport.cpp | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/cpptools/cppfindreferences.cpp b/src/plugins/cpptools/cppfindreferences.cpp index dfc519effd9..1d8911f7c67 100644 --- a/src/plugins/cpptools/cppfindreferences.cpp +++ b/src/plugins/cpptools/cppfindreferences.cpp @@ -79,7 +79,7 @@ static QString getSource(const QString &fileName, return workingCopy.source(fileName); } else { Utils::FileReader reader; - if (!reader.fetch(fileName)) // ### FIXME error reporting + if (!reader.fetch(fileName, QFile::Text)) // ### FIXME error reporting return QString(); return QString::fromLocal8Bit(reader.data()); // ### FIXME encoding diff --git a/src/plugins/cpptools/uicodecompletionsupport.cpp b/src/plugins/cpptools/uicodecompletionsupport.cpp index b72b682474e..f7e14c89cd1 100644 --- a/src/plugins/cpptools/uicodecompletionsupport.cpp +++ b/src/plugins/cpptools/uicodecompletionsupport.cpp @@ -68,7 +68,7 @@ void UiCodeModelSupport::init() const QDateTime uiHeaderTime = uiHeaderFileInfo.exists() ? uiHeaderFileInfo.lastModified() : QDateTime(); if (uiHeaderTime.isValid() && (uiHeaderTime > sourceTime)) { QFile file(m_fileName); - if (file.open(QFile::ReadOnly)) { + if (file.open(QFile::ReadOnly | QFile::Text)) { if (debug) qDebug()<<"ui*h file is more recent then source file, using information from ui*h file"<