feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ConsoleProcess: Make setSettings() a static member

Browse Source 
Since it's not possible to use directly ICore::settings()
inside Utils lib, make setSettings() a static member.
This simplifies the API of other static methods.
Set the settings just once now, inside main().

Change-Id: I2bcc58d4d29b5aba4a1a21a98a9f4245b24b530f
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2022-01-21 11:28:50 +01:00
parent b3375cfd56
commit 74f522e0de
8 changed files with 34 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/debugger/terminal.cpp
View File

@@ -209,13 +209,8 @@ void TerminalRunner::start()
m_stubProc.setEnvironment(stub.environment);
m_stubProc.setWorkingDirectory(stub.workingDirectory);
if (HostOsInfo::isWindowsHost()) {
m_stubProc.setMode(ConsoleProcess::Suspend);
} else {
m_stubProc.setMode(ConsoleProcess::Debug);
m_stubProc.setSettings(Core::ICore::settings());
}
m_stubProc.setMode(HostOsInfo::isWindowsHost() ? ConsoleProcess::Suspend
: ConsoleProcess::Debug);
// Error message for user is delivered via a signal.
m_stubProc.setCommand(stub.command);