feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

LSP: Make it obvious which functions need overloads

Browse Source 
Change-Id: Ib452770a2ec3938183428ac86bfb3955de231a13
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Marcus Tillmanns
2024-01-11 13:45:24 +01:00
parent 78b6306578
commit 75ac93db00
2 changed files with 2 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/languageclient/languageclientsettings.cpp
View File

@@ -557,11 +557,6 @@ Client *BaseSettings::createClient(ProjectExplorer::Project *project) const
return client; return client;
} }
BaseClientInterface *BaseSettings::createInterface(ProjectExplorer::Project *) const
{
return nullptr;
}
Client *BaseSettings::createClient(BaseClientInterface *interface) const Client *BaseSettings::createClient(BaseClientInterface *interface) const
{ {
return new Client(interface); return new Client(interface);

4
src/plugins/languageclient/languageclientsettings.h
View File

@@ -75,7 +75,7 @@ public:
virtual bool applyFromSettingsWidget(QWidget *widget); virtual bool applyFromSettingsWidget(QWidget *widget);
virtual QWidget *createSettingsWidget(QWidget *parent = nullptr) const; virtual QWidget *createSettingsWidget(QWidget *parent = nullptr) const;
virtual BaseSettings *copy() const { return new BaseSettings(*this); } virtual BaseSettings *copy() const = 0;
virtual bool isValid() const; virtual bool isValid() const;
Client *createClient() const; Client *createClient() const;
Client *createClient(ProjectExplorer::Project *project) const; Client *createClient(ProjectExplorer::Project *project) const;
@@ -83,7 +83,7 @@ public:
virtual void fromMap(const Utils::Store &map); virtual void fromMap(const Utils::Store &map);
protected: protected:
virtual BaseClientInterface *createInterface(ProjectExplorer::Project *) const; virtual BaseClientInterface *createInterface(ProjectExplorer::Project *) const = 0;
virtual Client *createClient(BaseClientInterface *interface) const; virtual Client *createClient(BaseClientInterface *interface) const;
BaseSettings(const BaseSettings &other) = default; BaseSettings(const BaseSettings &other) = default;