feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Replace some calls to IOutputParser::taskAdded

Browse Source 
... where the intention was to simply emit the addTask signal.

Change-Id: I74fb625cd8683d5f49f4a8e7b82086b3a3bccb38
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2020-04-07 11:55:10 +02:00
parent c58b1b2ca6
commit 763c15b4af
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/projectexplorer/xcodebuildparser.cpp
View File

@@ -76,7 +76,7 @@ void XcodebuildParser::stdOutput(const QString &line)
tr("Replacing signature"), tr("Replacing signature"),
FilePath::fromString( FilePath::fromString(
lne.left(lne.size() - QLatin1String(signatureChangeEndsWithPattern).size()))); lne.left(lne.size() - QLatin1String(signatureChangeEndsWithPattern).size())));
taskAdded(task, 1); emit addTask(task, 1);
return; return;
} }
IOutputParser::stdError(line); IOutputParser::stdError(line);
@@ -92,7 +92,7 @@ void XcodebuildParser::stdError(const QString &line)
++m_fatalErrorCount; ++m_fatalErrorCount;
m_xcodeBuildParserState = UnknownXcodebuildState; m_xcodeBuildParserState = UnknownXcodebuildState;
// unfortunately the m_lastTarget, m_lastProject might not be in sync // unfortunately the m_lastTarget, m_lastProject might not be in sync
taskAdded(CompileTask(Task::Error, tr("Xcodebuild failed."))); emit addTask(CompileTask(Task::Error, tr("Xcodebuild failed.")));
return; return;
} }
if (m_xcodeBuildParserState == OutsideXcodebuild) { // also forward if UnknownXcodebuildState ? if (m_xcodeBuildParserState == OutsideXcodebuild) { // also forward if UnknownXcodebuildState ?

2
src/plugins/qtsupport/qttestparser.cpp
View File

@@ -80,7 +80,7 @@ void QtTestParser::stdOutput(const QString &line)
void QtTestParser::emitCurrentTask() void QtTestParser::emitCurrentTask()
{ {
if (!m_currentTask.isNull()) { if (!m_currentTask.isNull()) {
emit taskAdded(m_currentTask); emit addTask(m_currentTask);
m_currentTask.clear(); m_currentTask.clear();
} }
} }