From 76e51ac5bb172b44ea55ff16829399c03566ff29 Mon Sep 17 00:00:00 2001 From: Alessandro Portale Date: Wed, 21 Sep 2016 16:08:35 +0200 Subject: [PATCH] Help: Fix some clang warnings Change-Id: I6e65e0819333d7d5e7f697718690bc8d80b1b189 Reviewed-by: Eike Ziller --- src/plugins/help/centralwidget.cpp | 4 ++-- src/plugins/help/localhelpmanager.cpp | 2 +- src/plugins/help/localhelpmanager.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/plugins/help/centralwidget.cpp b/src/plugins/help/centralwidget.cpp index a185b610744..cabc2d5ad22 100644 --- a/src/plugins/help/centralwidget.cpp +++ b/src/plugins/help/centralwidget.cpp @@ -32,7 +32,7 @@ using namespace Help::Internal; -CentralWidget *gStaticCentralWidget = 0; +static CentralWidget *gStaticCentralWidget = 0; // -- CentralWidget @@ -46,7 +46,7 @@ CentralWidget::CentralWidget(const Core::Context &context, QWidget *parent) CentralWidget::~CentralWidget() { // TODO: this shouldn't be done here - QList zoomFactors; + QList zoomFactors; QStringList currentPages; for (int i = 0; i < viewerCount(); ++i) { const HelpViewer * const viewer = viewerAt(i); diff --git a/src/plugins/help/localhelpmanager.cpp b/src/plugins/help/localhelpmanager.cpp index dee3ef7332d..28ebd548e24 100644 --- a/src/plugins/help/localhelpmanager.cpp +++ b/src/plugins/help/localhelpmanager.cpp @@ -263,7 +263,7 @@ QList LocalHelpManager::lastShownPagesZoom() return Utils::transform(stringValues, [](const QString &str) { return str.toFloat(); }); } -void LocalHelpManager::setLastShownPagesZoom(const QList &zoom) +void LocalHelpManager::setLastShownPagesZoom(const QList &zoom) { const QStringList stringValues = Utils::transform(zoom, [](float z) { return QString::number(z); }); diff --git a/src/plugins/help/localhelpmanager.h b/src/plugins/help/localhelpmanager.h index 4eae028e3ee..39ace0168b8 100644 --- a/src/plugins/help/localhelpmanager.h +++ b/src/plugins/help/localhelpmanager.h @@ -82,7 +82,7 @@ public: static void setLastShownPages(const QStringList &pages); static QList lastShownPagesZoom(); - static void setLastShownPagesZoom(const QList &zoom); + static void setLastShownPagesZoom(const QList &zoom); static int lastSelectedTab(); static void setLastSelectedTab(int index);