feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QMutableMapIterator uses map in destructor, use foreach.

Browse Source 
Change-Id: Ie8737acaea614fdda66cb7642eaed21be41cae64
Reviewed-by: Peter Kümmel <syntheticpp@gmx.net>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
This commit is contained in:
Friedemann Kleint
2011-10-27 14:50:42 +02:00
committed by Eike Ziller
parent b4a2612eb9
commit 77070354f2
1 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/coreplugin/sidebar.cpp
View File

@@ -111,12 +111,9 @@ SideBar::SideBar(QList<SideBarItem*> itemList,
SideBar::~SideBar()
{
QMutableMapIterator<QString, QWeakPointer<SideBarItem> > iter(d->m_itemMap);
while(iter.hasNext()) {
iter.next();
if (!iter.value().isNull())
delete iter.value().data();
}
foreach (const QWeakPointer<SideBarItem> &i, d->m_itemMap)
if (!i.isNull())
delete i.data();
delete d;
}