From 778839be5f612f4a1486d215b0a86d2c17d7e077 Mon Sep 17 00:00:00 2001 From: Miikka Heikkinen Date: Thu, 20 Jun 2024 14:45:06 +0300 Subject: [PATCH] QmlDesigner: Remove initial reparenting of all items to root item This initial reparenting to root doesn't seem to have a purpose as any valid instance will be reparented to its actual parent later anyway. Since it does break composed effects parent handling, it was removed. Fixes: QDS-12022 Change-Id: I08993424b5c3ece739809375c11d0a2cd0e3498c Reviewed-by: Thomas Hartmann --- .../qml2puppet/qml2puppet/instances/quickitemnodeinstance.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/tools/qml2puppet/qml2puppet/instances/quickitemnodeinstance.cpp b/src/tools/qml2puppet/qml2puppet/instances/quickitemnodeinstance.cpp index a9c49b96611..408864d4916 100644 --- a/src/tools/qml2puppet/qml2puppet/instances/quickitemnodeinstance.cpp +++ b/src/tools/qml2puppet/qml2puppet/instances/quickitemnodeinstance.cpp @@ -150,8 +150,6 @@ void QuickItemNodeInstance::initialize(const ObjectNodeInstance::Pointer &object if (instanceId() == 0) nodeInstanceServer()->setRootItem(quickItem()); - else - quickItem()->setParentItem(nodeInstanceServer()->rootItem()); ObjectNodeInstance::initialize(objectNodeInstance, flags); }