feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

IosTool: Don't restrict the number of pending connections

Browse Source 
Apparently a failed connection counts as "pending" for a while before
it is finally removed. The QML profiler aggressively tries to connect
with different timeouts and multiple sockets, so quite often there is
such a failed connection which then prevents new connections from
getting established.

We already enforce the limit of only one successful connection via the
SingleRelayServer subclass.

Change-Id: I441e2ed898d28f04359a9976d5b25569b8447f3f
Task-number: QTCREATORBUG-17141
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Ulf Hermann
2016-10-26 16:37:22 +02:00
parent bd2653fbaa
commit 779c54872a
1 changed files with 0 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/tools/iostool/main.cpp
View File

@@ -407,7 +407,6 @@ RelayServer::~RelayServer()
bool RelayServer::startServer(int port, bool ipv6) bool RelayServer::startServer(int port, bool ipv6)
{ {
QTC_CHECK(!m_server.isListening()); QTC_CHECK(!m_server.isListening());
m_server.setMaxPendingConnections(1);
connect(&m_server, &QTcpServer::newConnection, this, &RelayServer::handleNewRelayConnection); connect(&m_server, &QTcpServer::newConnection, this, &RelayServer::handleNewRelayConnection);
quint16 portValue = static_cast<quint16>(port); quint16 portValue = static_cast<quint16>(port);
if (port < 0 || port > 0xFFFF) if (port < 0 || port > 0xFFFF)