From 77c3e7d2d4476e05033306fb50bf6a451a00cb94 Mon Sep 17 00:00:00 2001 From: Tim Jenssen Date: Thu, 23 Apr 2020 04:53:21 +0200 Subject: [PATCH] languageutils: improve ComponentVersion::toString After benchmarking it on a i7 it was 20% faster in release. (in debug even more) Change-Id: Ibf4599813c2e3bc206ea77dea7fc972018554b09 Reviewed-by: Thomas Hartmann --- src/libs/languageutils/componentversion.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/libs/languageutils/componentversion.cpp b/src/libs/languageutils/componentversion.cpp index 3c7759d2327..8cfd46aa56e 100644 --- a/src/libs/languageutils/componentversion.cpp +++ b/src/libs/languageutils/componentversion.cpp @@ -73,8 +73,12 @@ bool ComponentVersion::isValid() const QString ComponentVersion::toString() const { - return QString::fromLatin1("%1.%2").arg(QString::number(_major), - QString::number(_minor)); + QByteArray temp; + QByteArray result; + result += temp.setNum(_major); + result += '.'; + result += temp.setNum(_minor); + return QString::fromLatin1(result); } void ComponentVersion::addToHash(QCryptographicHash &hash) const