feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ClangTools: Fix warning

Browse Source 
GCC 14.1.1 claims a dangling reference when using make_pair(). Using the
constructor instead makes the warning go away.

Change-Id: I10b4af781c36a6ae4d5a525e875cd369d2a051b6
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2024-07-16 12:35:29 +02:00
parent bd1829b56f
commit 77f549272e
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/clangtools/clangtoolsplugin.cpp
View File

@@ -177,10 +177,11 @@ void ClangToolsPlugin::registerAnalyzeActions()
widget->toolBar()->addWidget(button); widget->toolBar()->addWidget(button);
const auto toolsMenu = new QMenu(widget); const auto toolsMenu = new QMenu(widget);
button->setMenu(toolsMenu); button->setMenu(toolsMenu);
for (const auto &toolInfo : {std::make_pair(ClangTidyTool::instance(), for (const auto &toolInfo :
Constants::RUN_CLANGTIDY_ON_CURRENT_FILE), {std::pair<ClangTool *, Utils::Id>(
std::make_pair(ClazyTool::instance(), ClangTidyTool::instance(), Constants::RUN_CLANGTIDY_ON_CURRENT_FILE),
Constants::RUN_CLAZY_ON_CURRENT_FILE)}) { std::pair<ClangTool *, Utils::Id>(
ClazyTool::instance(), Constants::RUN_CLAZY_ON_CURRENT_FILE)}) {
ClangTool * const tool = toolInfo.first; ClangTool * const tool = toolInfo.first;
Command * const cmd = ActionManager::command(toolInfo.second); Command * const cmd = ActionManager::command(toolInfo.second);
QAction *const action = toolsMenu->addAction(tool->name(), [editor, tool] { QAction *const action = toolsMenu->addAction(tool->name(), [editor, tool] {