From 77fa73c5244c39cc1bcde7834ac7eb67bc90ec71 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Thu, 11 Jul 2024 12:28:23 +0200 Subject: [PATCH] Android: Fix potential process leak Make process a child of Target. Change-Id: If77a54120044829b6551cd0f6446e3edffa28558 Reviewed-by: Alessandro Portale --- src/plugins/android/androidmanager.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/android/androidmanager.cpp b/src/plugins/android/androidmanager.cpp index 47452057d0c..86a5de3854e 100644 --- a/src/plugins/android/androidmanager.cpp +++ b/src/plugins/android/androidmanager.cpp @@ -605,7 +605,7 @@ void installQASIPackage(Target *target, const FilePath &packagePath) QString error; Process *process = startAdbProcess(arguments, &error); if (process) { - // TODO: Potential leak when the process is still running on Creator shutdown. + process->setParent(target); QObject::connect(process, &Process::done, target, [process] { if (process->result() == ProcessResult::FinishedWithSuccess) { MessageManager::writeSilently(