From 78372726c1d3845554f5deb18d3d2639dbc1cd58 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Thu, 2 Sep 2021 08:53:18 +0200 Subject: [PATCH] Editor: fix marking proposal entries as explicitly selected The flag was set whenever the n or p key was pressed allthough we only switch the item if also control is pressed. Change-Id: Ib1b6ab14d1ddf7dee954651382b9b0fc454ddca1 Reviewed-by: Christian Kandeler --- src/plugins/texteditor/codeassist/genericproposalwidget.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/texteditor/codeassist/genericproposalwidget.cpp b/src/plugins/texteditor/codeassist/genericproposalwidget.cpp index ad056e41ad4..01283920246 100644 --- a/src/plugins/texteditor/codeassist/genericproposalwidget.cpp +++ b/src/plugins/texteditor/codeassist/genericproposalwidget.cpp @@ -618,8 +618,8 @@ bool GenericProposalWidget::eventFilter(QObject *o, QEvent *e) case Qt::Key_N: case Qt::Key_P: // select next/previous completion - d->m_explicitlySelected = true; if (ke->modifiers() == Qt::KeyboardModifiers(HostOsInfo::controlModifier())) { + d->m_explicitlySelected = true; int change = (ke->key() == Qt::Key_N) ? 1 : -1; int nrows = d->m_model->size(); int row = d->m_completionListView->currentIndex().row();