feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

runconfig: consolidate createConfigurationWidget implementations

Browse Source 
Most derived classes used essentially identical 'return 0;'
implementations. Use a base class implementation doing that instead.

Change-Id: I99727ac2230a5d9f168b4b0eb5927f8efff44e64
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
This commit is contained in:
hjk
2012-06-13 14:50:00 +02:00
committed by hjk
parent b2f6c7223d
commit 7853297f77
17 changed files with 6 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/android/androidrunfactories.cpp
View File

@@ -190,11 +190,5 @@ QString AndroidRunControlFactory::displayName() const
return tr("Run on Android device/emulator");
}
RunConfigWidget *AndroidRunControlFactory::createConfigurationWidget(RunConfiguration *config)
{
Q_UNUSED(config)
return 0;
}
} // namespace Internal
} // namespace Qt4ProjectManager

1
src/plugins/android/androidrunfactories.h
View File

@@ -80,7 +80,6 @@ public:
~AndroidRunControlFactory();
QString displayName() const;
RunConfigWidget *createConfigurationWidget(RunConfiguration *runConfiguration);
bool canRun(RunConfiguration *runConfiguration,
ProjectExplorer::RunMode mode) const;

6
src/plugins/madde/maemorunfactories.cpp
View File

@@ -191,11 +191,5 @@ QString MaemoRunControlFactory::displayName() const
return tr("Run on device");
}
RunConfigWidget *MaemoRunControlFactory::createConfigurationWidget(RunConfiguration *config)
{
Q_UNUSED(config)
return 0;
}
} // namespace Internal
} // namespace Madde

1
src/plugins/madde/maemorunfactories.h
View File

@@ -78,7 +78,6 @@ public:
~MaemoRunControlFactory();
QString displayName() const;
RunConfigWidget *createConfigurationWidget(RunConfiguration *runConfiguration);
bool canRun(ProjectExplorer::RunConfiguration *runConfiguration, ProjectExplorer::RunMode mode) const;
RunControl *create(ProjectExplorer::RunConfiguration *runConfiguration, ProjectExplorer::RunMode mode);

6
src/plugins/projectexplorer/localapplicationruncontrol.cpp
View File

@@ -73,12 +73,6 @@ RunControl *LocalApplicationRunControlFactory::create(RunConfiguration *runConfi
return new LocalApplicationRunControl(localRunConfiguration, mode);
}
RunConfigWidget *LocalApplicationRunControlFactory::createConfigurationWidget(RunConfiguration *runConfiguration)
{
Q_UNUSED(runConfiguration)
return 0;
}
// ApplicationRunControl
LocalApplicationRunControl::LocalApplicationRunControl(LocalApplicationRunConfiguration *rc, RunMode mode)

1
src/plugins/projectexplorer/localapplicationruncontrol.h
View File

@@ -51,7 +51,6 @@ public:
virtual bool canRun(RunConfiguration *runConfiguration, RunMode mode) const;
virtual QString displayName() const;
virtual RunControl* create(RunConfiguration *runConfiguration, RunMode mode);
virtual RunConfigWidget *createConfigurationWidget(RunConfiguration *runConfiguration);
};
class LocalApplicationRunControl : public RunControl

5
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -574,6 +574,11 @@ IRunConfigurationAspect *IRunControlFactory::createRunConfigurationAspect()
return 0;
}
RunConfigWidget *IRunControlFactory::createConfigurationWidget(RunConfiguration *)
{
return 0;
}
/*!
\class ProjectExplorer::RunControl
\brief Each instance of this class represents one item that is run.

2
src/plugins/projectexplorer/runconfiguration.h
View File

@@ -235,7 +235,7 @@ public:
virtual QString displayName() const = 0;
virtual IRunConfigurationAspect *createRunConfigurationAspect();
virtual RunConfigWidget *createConfigurationWidget(RunConfiguration *runConfiguration) = 0;
virtual RunConfigWidget *createConfigurationWidget(RunConfiguration *runConfiguration);
};
class PROJECTEXPLORER_EXPORT RunConfigWidget

6
src/plugins/qmlprojectmanager/qmlprojectruncontrol.cpp
View File

@@ -196,12 +196,6 @@ QString QmlProjectRunControlFactory::displayName() const
return tr("Run");
}
ProjectExplorer::RunConfigWidget *QmlProjectRunControlFactory::createConfigurationWidget(RunConfiguration *runConfiguration)
{
Q_UNUSED(runConfiguration)
return 0;
}
RunControl *QmlProjectRunControlFactory::createDebugRunControl(QmlProjectRunConfiguration *runConfig)
{
Debugger::DebuggerStartParameters params;

2
src/plugins/qmlprojectmanager/qmlprojectruncontrol.h
View File

@@ -81,8 +81,6 @@ public:
virtual bool canRun(ProjectExplorer::RunConfiguration *runConfiguration, ProjectExplorer::RunMode mode) const;
virtual ProjectExplorer::RunControl *create(ProjectExplorer::RunConfiguration *runConfiguration, ProjectExplorer::RunMode mode);
virtual QString displayName() const;
virtual ProjectExplorer::RunConfigWidget *createConfigurationWidget(ProjectExplorer::RunConfiguration
*runConfiguration);
private:
ProjectExplorer::RunControl *createDebugRunControl(QmlProjectRunConfiguration *runConfig);

5
src/plugins/qt4projectmanager/qt-s60/s60devicedebugruncontrol.cpp
View File

@@ -246,8 +246,3 @@ QString S60DeviceDebugRunControlFactory::displayName() const
{
return S60DeviceDebugRunControl::tr("Debug on Device");
}
ProjectExplorer::RunConfigWidget *S60DeviceDebugRunControlFactory::createConfigurationWidget(RunConfiguration* /*runConfiguration */)
{
return 0;
}

1
src/plugins/qt4projectmanager/qt-s60/s60devicedebugruncontrol.h
View File

@@ -78,7 +78,6 @@ public:
ProjectExplorer::RunControl* create(ProjectExplorer::RunConfiguration *runConfiguration, ProjectExplorer::RunMode mode);
QString displayName() const;
ProjectExplorer::RunConfigWidget *createConfigurationWidget(ProjectExplorer::RunConfiguration * /*runConfiguration */);
};
} // namespace Internal

4
src/plugins/qt4projectmanager/qt-s60/s60manager.cpp
View File

@@ -97,10 +97,6 @@ public:
return m_name;
}
ProjectExplorer::RunConfigWidget *createConfigurationWidget(ProjectExplorer::RunConfiguration *) {
return 0;
}
private:
const ProjectExplorer::RunMode m_mode;
const QString m_name;

6
src/plugins/qt4projectmanager/qt-s60/s60runcontrolfactory.cpp
View File

@@ -76,9 +76,3 @@ QString S60RunControlFactory::displayName() const
{
return m_name;
}
ProjectExplorer::RunConfigWidget *S60RunControlFactory::createConfigurationWidget(RunConfiguration *runConfiguration)
{
Q_UNUSED(runConfiguration);
return 0;
}

2
src/plugins/qt4projectmanager/qt-s60/s60runcontrolfactory.h
View File

@@ -53,8 +53,6 @@ public:
QString displayName() const;
ProjectExplorer::RunConfigWidget *createConfigurationWidget(ProjectExplorer::RunConfiguration *runConfiguration);
private:
const ProjectExplorer::RunMode m_mode;
const QString m_name;

6
src/plugins/remotelinux/remotelinuxruncontrolfactory.cpp
View File

@@ -101,11 +101,5 @@ QString RemoteLinuxRunControlFactory::displayName() const
return tr("Run on remote Linux device");
}
RunConfigWidget *RemoteLinuxRunControlFactory::createConfigurationWidget(RunConfiguration *config)
{
Q_UNUSED(config)
return 0;
}
} // namespace Internal
} // namespace RemoteLinux

1
src/plugins/remotelinux/remotelinuxruncontrolfactory.h
View File

@@ -44,7 +44,6 @@ public:
~RemoteLinuxRunControlFactory();
QString displayName() const;
ProjectExplorer::RunConfigWidget *createConfigurationWidget(ProjectExplorer::RunConfiguration *runConfiguration);
bool canRun(ProjectExplorer::RunConfiguration *runConfiguration,
ProjectExplorer::RunMode mode) const;