From 78b035f266179275312aab0f86cb99441f9c6ac9 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Tue, 1 Aug 2023 12:39:52 +0200 Subject: [PATCH] TaskTree: Make GroupItem subclasses final They are not meant to be derived from. Change-Id: I946565cffe27b4cb42915ba560c6dffcfda4ab43 Reviewed-by: Reviewed-by: Qt CI Bot Reviewed-by: Eike Ziller --- src/libs/solutions/tasking/tasktree.h | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/libs/solutions/tasking/tasktree.h b/src/libs/solutions/tasking/tasktree.h index 2cd6e42bdbf..339644f7406 100644 --- a/src/libs/solutions/tasking/tasktree.h +++ b/src/libs/solutions/tasking/tasktree.h @@ -267,16 +267,15 @@ TASKING_EXPORT extern const GroupItem stopOnFinished; TASKING_EXPORT extern const GroupItem finishAllAndDone; TASKING_EXPORT extern const GroupItem finishAllAndError; -class TASKING_EXPORT Storage : public GroupItem +class TASKING_EXPORT Storage final : public GroupItem { public: Storage(const TreeStorageBase &storage) : GroupItem(storage) { } }; // Synchronous invocation. Similarly to Group - isn't counted as a task inside taskCount() -class TASKING_EXPORT Sync : public Group +class TASKING_EXPORT Sync final : public Group { - public: template Sync(Function &&function) : Group(init(std::forward(function))) {} @@ -314,7 +313,7 @@ private: }; template -class CustomTask : public GroupItem +class CustomTask final : public GroupItem { public: using Task = typename Adapter::Type;