feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AutoTest: Rename results executable

Browse Source 
Rename member to better reflect its meaning. It is used
as an identifier and might be something else than an
executable.

Change-Id: I082e3caaa3d94fcd7ab26ebc43bb0eb6da136d57
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Christian Stenger
2018-05-09 10:48:23 +02:00
committed by David Schulz
parent 1f3381a3c2
commit 78bd3f9ec3
13 changed files with 25 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/autotest/testresult.cpp
View File

@@ -47,8 +47,8 @@ TestResult::TestResult(const QString &name)
{
}
TestResult::TestResult(const QString &executable, const QString &name)
: m_executable(executable)
TestResult::TestResult(const QString &id, const QString &name)
: m_id(id)
, m_name(name)
{
}
@@ -185,21 +185,19 @@ bool TestResult::isMessageCaseStart(const Result::Type type)
bool TestResult::isDirectParentOf(const TestResult *other, bool * /*needsIntermediate*/) const
{
QTC_ASSERT(other, return false);
return !m_executable.isEmpty() && m_executable == other->m_executable
&& m_name == other->m_name;
return !m_id.isEmpty() && m_id == other->m_id && m_name == other->m_name;
}
bool TestResult::isIntermediateFor(const TestResult *other) const
{
QTC_ASSERT(other, return false);
return !m_executable.isEmpty() && m_executable == other->m_executable
&& m_name == other->m_name;
return !m_id.isEmpty() && m_id == other->m_id && m_name == other->m_name;
}
TestResult *TestResult::createIntermediateResultFor(const TestResult *other)
{
QTC_ASSERT(other, return nullptr);
TestResult *intermediate = new TestResult(other->m_executable, other->m_name);
TestResult *intermediate = new TestResult(other->m_id, other->m_name);
return intermediate;
}