From 78cfd73037245ad4c928d7ab93226df41668f375 Mon Sep 17 00:00:00 2001 From: Henning Gruendl Date: Wed, 30 Aug 2023 16:46:41 +0200 Subject: [PATCH] ADS: Fix crash in auto hide tab * Crash is caused by dragging an autohide tab out when it is an icon only * The crash can actually happen with non icon only tabs, but is masked by the orientation check Base repository commit 61573cba1633600dddcbf5afb7d8ed1645f82b30 Change-Id: I1aebfd6455983662050aaf82a6506a6a5a40421e Reviewed-by: Tim Jenssen --- src/libs/advanceddockingsystem/autohidetab.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/libs/advanceddockingsystem/autohidetab.cpp b/src/libs/advanceddockingsystem/autohidetab.cpp index c6bfd7bdb8b..1d8f7a50a65 100644 --- a/src/libs/advanceddockingsystem/autohidetab.cpp +++ b/src/libs/advanceddockingsystem/autohidetab.cpp @@ -408,7 +408,8 @@ void AutoHideTab::mouseReleaseEvent(QMouseEvent *event) case DraggingFloatingWidget: event->accept(); d->m_floatingWidget->finishDragging(); - if (d->m_dockWidget->isAutoHide() && d->m_dragStartOrientation != orientation()) + if (d->m_dockWidget->autoHideDockContainer() + && d->m_dragStartOrientation != orientation()) d->m_dockWidget->autoHideDockContainer()->resetToInitialDockWidgetSize(); break;