From 79573f2c76cf6fd1dfc3cce48578b1222df63121 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Tue, 12 Mar 2024 11:26:41 +0100 Subject: [PATCH] CppEditor: Don't leak CppCodeStylePreferences Change-Id: I4414c69cebaeb429c5b6dfea6e6fa97b118e353e Reviewed-by: Christian Kandeler --- src/plugins/cppeditor/cppcodestylesettingspage.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/plugins/cppeditor/cppcodestylesettingspage.cpp b/src/plugins/cppeditor/cppcodestylesettingspage.cpp index 2ad6ba8baa9..ba0fc189417 100644 --- a/src/plugins/cppeditor/cppcodestylesettingspage.cpp +++ b/src/plugins/cppeditor/cppcodestylesettingspage.cpp @@ -562,7 +562,7 @@ public: CppCodeStyleSettingsPageWidget() { CppCodeStylePreferences *originalCodeStylePreferences = CppToolsSettings::cppCodeStyle(); - m_pageCppCodeStylePreferences = new CppCodeStylePreferences(); + m_pageCppCodeStylePreferences.reset(new CppCodeStylePreferences); m_pageCppCodeStylePreferences->setDelegatingPool( originalCodeStylePreferences->delegatingPool()); m_pageCppCodeStylePreferences->setCodeStyleSettings( @@ -573,7 +573,7 @@ public: m_pageCppCodeStylePreferences->setId(originalCodeStylePreferences->id()); m_codeStyleEditor = TextEditorSettings::codeStyleFactory(CppEditor::Constants::CPP_SETTINGS_ID) - ->createCodeStyleEditor(m_pageCppCodeStylePreferences); + ->createCodeStyleEditor(m_pageCppCodeStylePreferences.get()); auto hbox = new QVBoxLayout(this); hbox->addWidget(m_codeStyleEditor); @@ -603,7 +603,7 @@ public: m_codeStyleEditor->finish(); } - CppCodeStylePreferences *m_pageCppCodeStylePreferences = nullptr; + std::unique_ptr m_pageCppCodeStylePreferences; CodeStyleEditorWidget *m_codeStyleEditor; };