feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Theming: debugger

Browse Source 
Theme the text colors of
- the debugger's log window
- the debugger's watch items

In particular, the watch items were hard to read (default color was
black, color for changed value was red).

For the dark theme, the default color for watch items is now white
(the text color), changed items appear red, and invalid items
appear grey.

Change-Id: I7f9534b054c44d635b106fa0e9ac70479c9fcac5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Thorben Kroeger
2015-03-19 20:44:18 +01:00
committed by hjk
parent 8b46f0d6ef
commit 797af15584
5 changed files with 53 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
src/plugins/debugger/watchhandler.cpp
View File

@@ -49,6 +49,7 @@
#include <utils/qtcassert.h>
#include <utils/savedaction.h>
#include <utils/checkablemessagebox.h>
#include <utils/theme/theme.h>
#include <QDebug>
#include <QFile>
@@ -712,19 +713,19 @@ QString WatchItem::displayType() const
QColor WatchItem::valueColor() const
{
static const QColor red(200, 0, 0);
static const QColor gray(140, 140, 140);
using Utils::Theme;
Theme *theme = Utils::creatorTheme();
if (watchModel()) {
if (!valueEnabled)
return gray;
return theme->color(Theme::Debugger_WatchItem_ValueInvalid);
if (!watchModel()->m_contentsValid && !isInspect())
return gray;
return theme->color(Theme::Debugger_WatchItem_ValueInvalid);
if (value.isEmpty()) // This might still show 0x...
return gray;
return theme->color(Theme::Debugger_WatchItem_ValueInvalid);
if (value != watchModel()->m_valueCache.value(iname))
return red;
return theme->color(Theme::Debugger_WatchItem_ValueChanged);
}
return QColor();
return theme->color(Theme::Debugger_WatchItem_ValueNormal);
}
QVariant WatchItem::data(int column, int role) const