From 79cc12ab8cb3cbdfb02a485f7bb2a46eaf717d61 Mon Sep 17 00:00:00 2001 From: Sami Shalayel Date: Thu, 31 Aug 2023 13:57:09 +0200 Subject: [PATCH] qmljseditordocument: fix quickfix shortkey QtC shows qmlls's warnings, but does not apply quick fixes to it when using the quickfix shortkey. In quickFixAssistProvider, use the base class implementation to detect running language clients and apply their quickfixes, and fallback to the builtin qml code model quickfix if no language client is running. Fixes: QTCREATORBUG-29557 Change-Id: I75262d13ab229f8d3b4069fc0003574d41cabab0 Reviewed-by: David Schulz --- src/plugins/qmljseditor/qmljseditordocument.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/plugins/qmljseditor/qmljseditordocument.cpp b/src/plugins/qmljseditor/qmljseditordocument.cpp index 3b865570aca..065e39e0c37 100644 --- a/src/plugins/qmljseditor/qmljseditordocument.cpp +++ b/src/plugins/qmljseditor/qmljseditordocument.cpp @@ -856,6 +856,8 @@ Internal::QmlOutlineModel *QmlJSEditorDocument::outlineModel() const TextEditor::IAssistProvider *QmlJSEditorDocument::quickFixAssistProvider() const { + if (const auto baseProvider = TextDocument::quickFixAssistProvider()) + return baseProvider; return Internal::QmlJSEditorPlugin::quickFixAssistProvider(); }