From 79f9449f68855280caf9a79aa709b18f2089dd00 Mon Sep 17 00:00:00 2001 From: hjk Date: Thu, 1 Aug 2019 14:06:37 +0200 Subject: [PATCH] CompilationDataBasePM: Do not delay creating targets A target can/should handle/use unparsed projects just fine. Change-Id: I54b8399eab4b4fe7ead2de3cef8ab25cc7bbc621 Reviewed-by: Christian Kandeler --- .../compilationdatabaseproject.cpp | 7 +------ .../compilationdatabaseproject.h | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.cpp b/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.cpp index 4c4eb20a7e7..0dc865bd4e1 100644 --- a/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.cpp +++ b/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.cpp @@ -405,12 +405,7 @@ CompilationDatabaseProject::CompilationDatabaseProject(const Utils::FilePath &pr setPreferredKitPredicate([](const Kit *) { return false; }); m_kit.reset(KitManager::defaultKit()->clone()); - connect(this, &CompilationDatabaseProject::parsingFinished, this, [this]() { - if (!m_hasTarget) { - addTarget(createTarget(m_kit.get())); - m_hasTarget = true; - } - }); + addTarget(createTarget(m_kit.get())); connect(this, &CompilationDatabaseProject::rootProjectDirectoryChanged, m_parseDelay, QOverload<>::of(&QTimer::start)); diff --git a/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.h b/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.h index 7597e78cc3b..2ea4b870eca 100644 --- a/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.h +++ b/src/plugins/compilationdatabaseprojectmanager/compilationdatabaseproject.h @@ -74,7 +74,6 @@ private: MimeBinaryCache m_mimeBinaryCache; QTimer * const m_parseDelay; CompilationDbParser *m_parser = nullptr; - bool m_hasTarget = false; }; class CompilationDatabaseEditorFactory : public TextEditor::TextEditorFactory