From 7a074608b6a18482ad7cca36bc7bdacba3cac11f Mon Sep 17 00:00:00 2001 From: Cristian Adam Date: Wed, 9 Jun 2021 19:57:11 +0200 Subject: [PATCH] CMakePM: Do not emit error signal in destructor while project is parsed Do not emit error occurred in the fileapireader destructor if it's parsing. This will cause the fallback file system view tree to be generated just before the parsing will be stopped. This can lead to crashes. Task-number: QTCREATORBUG-25837 Change-Id: Ic7a2dfc394ed8e259da3366727a3c5fa65d98776 Reviewed-by: Jarek Kobus --- src/plugins/cmakeprojectmanager/fileapireader.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/plugins/cmakeprojectmanager/fileapireader.cpp b/src/plugins/cmakeprojectmanager/fileapireader.cpp index e5172e6f6e5..b19cd2068ec 100644 --- a/src/plugins/cmakeprojectmanager/fileapireader.cpp +++ b/src/plugins/cmakeprojectmanager/fileapireader.cpp @@ -64,8 +64,6 @@ FileApiReader::FileApiReader() FileApiReader::~FileApiReader() { - if (isParsing()) - emit errorOccurred(tr("Parsing has been canceled.")); stop(); resetData(); }