CMake: Fix inconsistent copy ctor/operator=

Detected by GCC9.

Looks like inCMakeCache was left out by mistake in df62701801.

Change-Id: I231d0d3e102edb95b657aef42c3f2f2f834514a0
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>

src/plugins/cmakeprojectmanager/builddirparameters.cpp

@@ -90,6 +90,7 @@ CMakeTool *BuildDirParameters::cmakeTool() const
 }
 
 BuildDirParameters::BuildDirParameters(const BuildDirParameters &) = default;
+BuildDirParameters &BuildDirParameters::operator=(const BuildDirParameters &) = default;
 
 } // namespace Internal
 } // namespace CMakeProjectManager

src/plugins/cmakeprojectmanager/builddirparameters.h

@@ -44,6 +44,7 @@ public:
     BuildDirParameters();
     BuildDirParameters(CMakeBuildConfiguration *bc);
     BuildDirParameters(const BuildDirParameters &other);
+    BuildDirParameters &operator=(const BuildDirParameters &other);
 
     bool isValid() const;
     CMakeTool *cmakeTool() const;

src/plugins/cmakeprojectmanager/cmakeconfigitem.cpp

@@ -42,12 +42,6 @@ namespace CMakeProjectManager {
 
 CMakeConfigItem::CMakeConfigItem() = default;
 
-CMakeConfigItem::CMakeConfigItem(const CMakeConfigItem &other) : // What about inCMakeCache?
-    key(other.key), type(other.type), isAdvanced(other.isAdvanced),
-    isUnset(other.isUnset), value(other.value),
-    documentation(other.documentation), values(other.values)
-{}
-
 CMakeConfigItem::CMakeConfigItem(const QByteArray &k, Type t,
                                  const QByteArray &d, const QByteArray &v) :
     key(k), type(t), value(v), documentation(d)

src/plugins/cmakeprojectmanager/cmakeconfigitem.h

@@ -42,7 +42,6 @@ class CMakeConfigItem {
 public:
     enum Type { FILEPATH, PATH, BOOL, STRING, INTERNAL, STATIC };
     CMakeConfigItem();
-    CMakeConfigItem(const CMakeConfigItem &other);
     CMakeConfigItem(const QByteArray &k, Type t, const QByteArray &d, const QByteArray &v);
     CMakeConfigItem(const QByteArray &k, const QByteArray &v);