feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Standardize on int for line and column values

Browse Source 
Recently tons of warnings show up for presumably "problematic"
singned <-> unsigned and size conversions.

The Qt side uses 'int', and that's the biggest 'integration surface'
for us, so instead of establishing some internal boundary between
signed and unsigned areas, push that boundary out of creator core code,
and use 'int' everywhere.

Because it reduces friction further, also do it in libcplusplus.

Change-Id: I84f3b79852c8029713e7ea6f133ffb9ef7030a70
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
hjk
2019-07-24 18:40:10 +02:00
parent eab0df22f9
commit 7ab6783e24
153 changed files with 3181 additions and 3194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/libs/3rdparty/cplusplus/Symbol.h vendored
View File

@@ -54,20 +54,20 @@ public:
public:
/// Constructs a Symbol with the given source location, name and translation unit.
Symbol(TranslationUnit *translationUnit, unsigned sourceLocation, const Name *name);
Symbol(TranslationUnit *translationUnit, int sourceLocation, const Name *name);
Symbol(Clone *clone, Subst *subst, Symbol *original);
/// Destroy this Symbol.
virtual ~Symbol();
/// Returns this Symbol's source location.
unsigned sourceLocation() const;
int sourceLocation() const;
/// \returns this Symbol's line number. The line number is 1-based.
unsigned line() const;
int line() const;
/// \returns this Symbol's column number. The column number is 1-based.
unsigned column() const;
int column() const;
/// Returns this Symbol's file name.
const StringLiteral *fileId() const;
@@ -76,7 +76,7 @@ public:
const char *fileName() const;
/// Returns this Symbol's file name length.
unsigned fileNameLength() const;
int fileNameLength() const;
/// Returns this Symbol's name.
const Name *name() const;
@@ -294,7 +294,7 @@ public:
void setEnclosingScope(Scope *enclosingScope); // ### make me private
void resetEnclosingScope(); // ### make me private
void setSourceLocation(unsigned sourceLocation, TranslationUnit *translationUnit); // ### make me private
void setSourceLocation(int sourceLocation, TranslationUnit *translationUnit); // ### make me private
void visitSymbol(SymbolVisitor *visitor);
static void visitSymbol(Symbol *symbol, SymbolVisitor *visitor);
@@ -309,13 +309,13 @@ private:
Scope *_enclosingScope;
Symbol *_next;
const StringLiteral *_fileId;
unsigned _sourceLocation;
int _sourceLocation;
unsigned _hashCode;
int _storage;
int _visibility;
unsigned _index;
unsigned _line;
unsigned _column;
int _index;
int _line;
int _column;
bool _isGenerated: 1;
bool _isDeprecated: 1;