feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Standardize on int for line and column values

Browse Source 
Recently tons of warnings show up for presumably "problematic"
singned <-> unsigned and size conversions.

The Qt side uses 'int', and that's the biggest 'integration surface'
for us, so instead of establishing some internal boundary between
signed and unsigned areas, push that boundary out of creator core code,
and use 'int' everywhere.

Because it reduces friction further, also do it in libcplusplus.

Change-Id: I84f3b79852c8029713e7ea6f133ffb9ef7030a70
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
hjk
2019-07-24 18:40:10 +02:00
parent eab0df22f9
commit 7ab6783e24
153 changed files with 3181 additions and 3194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
src/plugins/cpptools/cppsourceprocessor.h
View File

@@ -93,20 +93,20 @@ private:
// Client interface
void macroAdded(const CPlusPlus::Macro &macro) override;
void passedMacroDefinitionCheck(unsigned bytesOffset, unsigned utf16charsOffset,
unsigned line, const CPlusPlus::Macro &macro) override;
void failedMacroDefinitionCheck(unsigned bytesOffset, unsigned utf16charOffset,
void passedMacroDefinitionCheck(int bytesOffset, int utf16charsOffset,
int line, const CPlusPlus::Macro &macro) override;
void failedMacroDefinitionCheck(int bytesOffset, int utf16charOffset,
const CPlusPlus::ByteArrayRef &name) override;
void notifyMacroReference(unsigned bytesOffset, unsigned utf16charOffset,
unsigned line, const CPlusPlus::Macro &macro) override;
void startExpandingMacro(unsigned bytesOffset, unsigned utf16charOffset,
unsigned line, const CPlusPlus::Macro &macro,
void notifyMacroReference(int bytesOffset, int utf16charOffset,
int line, const CPlusPlus::Macro &macro) override;
void startExpandingMacro(int bytesOffset, int utf16charOffset,
int line, const CPlusPlus::Macro &macro,
const QVector<CPlusPlus::MacroArgumentReference> &actuals) override;
void stopExpandingMacro(unsigned bytesOffset, const CPlusPlus::Macro &macro) override;
void stopExpandingMacro(int bytesOffset, const CPlusPlus::Macro &macro) override;
void markAsIncludeGuard(const QByteArray &macroName) override;
void startSkippingBlocks(unsigned utf16charsOffset) override;
void stopSkippingBlocks(unsigned utf16charsOffset) override;
void sourceNeeded(unsigned line, const QString &fileName, IncludeType type,
void startSkippingBlocks(int utf16charsOffset) override;
void stopSkippingBlocks(int utf16charsOffset) override;
void sourceNeeded(int line, const QString &fileName, IncludeType type,
const QStringList &initialIncludes) override;
private: