feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Standardize on int for line and column values

Browse Source 
Recently tons of warnings show up for presumably "problematic"
singned <-> unsigned and size conversions.

The Qt side uses 'int', and that's the biggest 'integration surface'
for us, so instead of establishing some internal boundary between
signed and unsigned areas, push that boundary out of creator core code,
and use 'int' everywhere.

Because it reduces friction further, also do it in libcplusplus.

Change-Id: I84f3b79852c8029713e7ea6f133ffb9ef7030a70
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@qt.io>
This commit is contained in:
hjk
2019-07-24 18:40:10 +02:00
parent eab0df22f9
commit 7ab6783e24
153 changed files with 3181 additions and 3194 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/debugger/disassemblerlines.h
View File

@@ -52,7 +52,7 @@ public:
QString function; // (ass) Function to which current instruction belongs.
QString fileName; // (src) Source file
uint offset = 0; // (ass) Offset of instruction in relation to current function.
uint lineNumber = 0; // (src) Line number in source.
int lineNumber = 0; // (src) Line number in source.
uint hunk = 0; // (src) Number of hunk if source line was split
QByteArray rawData; // (ass) Raw bytes of the instruction
QString data; // (ass) Instruction text, (src) source text, (cmt) arbitrary.
@@ -69,7 +69,7 @@ public:
void appendLine(const DisassemblerLine &dl);
void appendComment(const QString &line);
// Mixed source/assembly: Retrieve contents of source (cached)
void appendSourceLine(const QString &fileName, uint line);
void appendSourceLine(const QString &fileName, int line);
QString toString() const;
void setBytesLength(int x) { m_bytesLength = x; }
int bytesLength() const { return m_bytesLength; }