forked from qt-creator/qt-creator
VCS: Refactor fileNameFromDiffSpecification
Use diff file pattern to match file name. Avoid duplication. Include unit tests for Git Change-Id: Ib68a08368270a27976a3e16bdd1cb219a52b8889 Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
committed by
Orgad Shaneh
parent
57ee50d52f
commit
7b39f41c05
@@ -46,9 +46,7 @@ public:
|
||||
private:
|
||||
QSet<QString> annotationChanges() const;
|
||||
QString changeUnderCursor(const QTextCursor &cursor) const;
|
||||
QRegExp diffFilePattern() const;
|
||||
VcsBase::BaseAnnotationHighlighter *createAnnotationHighlighter(const QSet<QString> &changes, const QColor &bg) const;
|
||||
QString fileNameFromDiffSpecification(const QTextBlock &diffFileSpec) const;
|
||||
QString decorateVersion(const QString &revision) const;
|
||||
QStringList annotationPreviousVersions(const QString &revision) const;
|
||||
|
||||
@@ -56,7 +54,6 @@ private:
|
||||
mutable QRegExp exactIdentifier40;
|
||||
mutable QRegExp changesetIdentifier12;
|
||||
const QRegExp changesetIdentifier40;
|
||||
const QRegExp diffIdentifier;
|
||||
};
|
||||
|
||||
} // namespace Internal
|
||||
|
||||
Reference in New Issue
Block a user