feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Suppress gdb warnings regarding controlling terminal

Browse Source 
Causes more confusion for users than actual trouble. A hint is
still left in the debugger log, so it's not completely gone.

Task-number: QTCREATORBUG-3918
Change-Id: I51244094811bcb5c436f0631cb02dbf41cc202bf
Reviewed-by: Christian Stenger <christian.stenger@theqtcompany.com>
This commit is contained in:
hjk
2015-03-05 12:50:57 +01:00
parent 4a1b6c1fd8
commit 7b3a185d41
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
src/plugins/debugger/gdb/gdbengine.cpp
View File

@@ -163,6 +163,13 @@ static QByteArray parsePlainConsoleStream(const DebuggerResponse &response)
return out.mid(pos + 3);
}
static bool isMostlyHarmlessMessage(const QByteArray &msg)
{
return msg == "warning: GDB: Failed to set controlling terminal: "
"Inappropriate ioctl for device\\n"
|| msg == "warning: GDB: Failed to set controlling terminal: Invalid argument\\n";
}
///////////////////////////////////////////////////////////////////////
//
// Debuginfo Taskhandler
@@ -339,6 +346,8 @@ static inline QString msgWinException(const QByteArray &data, unsigned *exCodeIn
void GdbEngine::readDebugeeOutput(const QByteArray &data)
{
if (isMostlyHarmlessMessage(data.mid(2, data.size() - 4)))
return;
QString msg = m_outputCodec->toUnicode(data.constData(), data.length(),
&m_outputCodecState);
showMessage(msg, AppOutput);
@@ -657,11 +666,17 @@ void GdbEngine::handleResponse(const QByteArray &buff)
case '&': {
QByteArray data = GdbMi::parseCString(from, to);
m_pendingLogStreamOutput += data;
// On Windows, the contents seem to depend on the debugger
// version and/or OS version used.
if (data.startsWith("warning:"))
if (data.startsWith("warning:")) {
if (isMostlyHarmlessMessage(data)) {
showMessage(_("Mostly harmless terminal warning suppressed."), LogWarning);
break;
}
showMessage(_(data.mid(9)), AppStuff); // Cut "warning: "
}
m_pendingLogStreamOutput += data;
if (isGdbConnectionError(data)) {
notifyInferiorExited();